Skip to content

fix: typo in React-cxxreact.podspec#49879

Closed
DorianMazur wants to merge 1 commit into
facebook:mainfrom
DorianMazur:fix/typo_in_React-cxxreact.podspec
Closed

fix: typo in React-cxxreact.podspec#49879
DorianMazur wants to merge 1 commit into
facebook:mainfrom
DorianMazur:fix/typo_in_React-cxxreact.podspec

Conversation

@DorianMazur
Copy link
Copy Markdown
Contributor

Summary:

This pull request includes a minor change to the React-cxxreact.podspec file in the ReactCommon/cxxreact package. The change corrects a typo in the HEADER_SEARCH_PATHS configuration.

Changelog:

[IOS] [FIXED] - Corrected the path from "$(PODS_ROOT)/fas_float/include" to "$(PODS_ROOT)/fast_float/include" in the HEADER_SEARCH_PATHS configuration.

Test Plan:

@facebook-github-bot
Copy link
Copy Markdown
Contributor

Hi @DorianMazur!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@facebook-github-bot
Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Mar 7, 2025
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@javache has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Mar 7, 2025
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@javache merged this pull request in 0188101.

@react-native-bot
Copy link
Copy Markdown
Collaborator

This pull request was successfully merged by @DorianMazur in 0188101

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants