Fix bug that prevents the Old Arch from being enabled#49896
Closed
cipolleschi wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Summary: This change makes possible to opt-out from the New Architecture. Env variables are always `string`s in ruby and the check was always failing because it was comparing it with a number (always false) ## Changelog: [iOS][Fixed] - enable back the opt-out from the New Architecture Differential Revision: D70789827
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70789827 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70789827 |
cipolleschi
force-pushed
the
export-D70789827
branch
from
3d3e16e to
c709656
Compare
Contributor
|
This pull request has been merged in 9abdd61. |
Collaborator
|
This pull request was successfully merged by @cipolleschi in 9abdd61 When will my fix make it into a release? | How to file a pick request? |
react-native-bot
pushed a commit
that referenced
this pull request
Mar 10, 2025
Summary: Pull Request resolved: #49896 This change makes possible to opt-out from the New Architecture. Env variables are always `string`s in ruby and the check was always failing because it was comparing it with a number (always false) ## Changelog: [iOS][Fixed] - enable back the opt-out from the New Architecture Reviewed By: cortinico Differential Revision: D70789827 fbshipit-source-id: 7d3f96c3db22f2715dec2b649534b20e3273ea3e
Collaborator
|
This pull request was successfully merged by @cipolleschi in 2f4dbc6 When will my fix make it into a release? | How to file a pick request? |
This was referenced Apr 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This change makes possible to opt-out from the New Architecture.
Env variables are always
strings in ruby and the check was always failing because it was comparing it with a number (always false)Changelog:
[iOS][Fixed] - enable back the opt-out from the New Architecture
Differential Revision: D70789827