Add warning when RCT_EXPORT_MODULE is used in New Arch#49897
Closed
cipolleschi wants to merge 1 commit into
Closed
Add warning when RCT_EXPORT_MODULE is used in New Arch#49897cipolleschi wants to merge 1 commit into
cipolleschi wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70789672 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70789672 |
cipolleschi
force-pushed
the
export-D70789672
branch
from
2226b60 to
ed23cce
Compare
cipolleschi
force-pushed
the
export-D70789672
branch
from
ed23cce to
635b2a3
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70789672 |
cipolleschi
force-pushed
the
export-D70789672
branch
from
635b2a3 to
8a78452
Compare
cipolleschi
force-pushed
the
export-D70789672
branch
from
8a78452 to
b7ec071
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70789672 |
cipolleschi
force-pushed
the
export-D70789672
branch
from
b7ec071 to
c615654
Compare
cipolleschi
force-pushed
the
export-D70789672
branch
from
0814273 to
6246b68
Compare
cipolleschi
force-pushed
the
export-D70789672
branch
from
c615654 to
0814273
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70789672 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70789672 |
cipolleschi
force-pushed
the
export-D70789672
branch
from
6246b68 to
461053f
Compare
cipolleschi
force-pushed
the
export-D70789672
branch
from
461053f to
ac25928
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70789672 |
cipolleschi
force-pushed
the
export-D70789672
branch
from
ac25928 to
6a3f816
Compare
Summary: Pull Request resolved: facebook#49897 This change introduces the first warning for the New Architecture warning. When modules are registered through the RCT_EXPORT_MODULE (or its variants) a warning is emitted. Note: currently it is only emitted on the Xcode console. I'm looking into ways to emit it also in the RN DevTools console. ## Changelog: [iOS][Added] - Show warnings in the New Architecture when modules are loaded using RCT_EXPORT_MODULE Differential Revision: D70789672
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70789672 |
cipolleschi
force-pushed
the
export-D70789672
branch
from
6a3f816 to
caa8a85
Compare
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Mar 21, 2025
Summary: Pull Request resolved: facebook#49897 This change introduces the first warning for the New Architecture warning. When modules are registered through the RCT_EXPORT_MODULE (or its variants) a warning is emitted. Note: currently it is only emitted on the Xcode console. I'm looking into ways to emit it also in the RN DevTools console. ## Changelog: [iOS][Added] - Show warnings in the New Architecture when modules are loaded using RCT_EXPORT_MODULE Differential Revision: D70789672
Contributor
|
This pull request has been merged in 4d40882. |
Collaborator
|
This pull request was successfully merged by @cipolleschi in 4d40882 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This change introduces the first warning for the New Architecture warning.
When modules are registered through the RCT_EXPORT_MODULE (or its variants) a warning is emitted.
Note: currently it is only emitted on the Xcode console.
I'm looking into ways to emit it also in the RN DevTools console.
Changelog:
[iOS][Added] - Show warnings in the New Architecture when modules are loaded using RCT_EXPORT_MODULE
Differential Revision: D70789672