Disable no-react-native-imports rule in Fantom tests#49911
Closed
rubennorte wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70779721 |
rubennorte
force-pushed
the
export-D70779721
branch
from
40ed1e2 to
6fd0e91
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70779721 |
rubennorte
force-pushed
the
export-D70779721
branch
from
6fd0e91 to
f367074
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70779721 |
rubennorte
force-pushed
the
export-D70779721
branch
2 times, most recently
from
5a2a8ec to
0ff0399
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70779721 |
rubennorte
force-pushed
the
export-D70779721
branch
from
0ff0399 to
7638878
Compare
Summary: Changelog: [internal] The approach in Fantom tests is to use the public API as much as we can, but forcing us to use relative imports in tests makes it harder to see what's the public API and what's not. This disables the lint rule so we can use package imports in Fantom tests without warnings/errors. Reviewed By: sammy-SC Differential Revision: D70779721
rubennorte
force-pushed
the
export-D70779721
branch
from
7638878 to
829e4b4
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70779721 |
Contributor
|
This pull request has been merged in bc808a5. |
Collaborator
|
This pull request was successfully merged by @rubennorte in bc808a5 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
The approach in Fantom tests is to use the public API as much as we can, but forcing us to use relative imports in tests makes it harder to see what's the public API and what's not. This disables the lint rule so we can use package imports in Fantom tests without warnings/errors.
Differential Revision: D70779721