Skip to content

Make WritableMapBuffer internal #49914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mateoguzmana wants to merge 2 commits into from
Closed

Make WritableMapBuffer internal #49914

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ecba26
Make WritableMapBuffer internal
mateoguzmana Mar 9, 2025
f3881ef
Merge branch 'main' of github.com:mateoguzmana/react-native into refa…
mateoguzmana Mar 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 0 additions & 23 deletions packages/react-native/ReactAndroid/api/ReactAndroid.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1904,29 +1904,6 @@ public final class com/facebook/react/common/mapbuffer/ReadableMapBuffer : com/f
public final class com/facebook/react/common/mapbuffer/ReadableMapBuffer$Companion {
}

public final class com/facebook/react/common/mapbuffer/WritableMapBuffer : com/facebook/react/common/mapbuffer/MapBuffer {
public fun <init> ()V
public fun contains (I)Z
public fun entryAt (I)Lcom/facebook/react/common/mapbuffer/MapBuffer$Entry;
public fun getBoolean (I)Z
public fun getCount ()I
public fun getDouble (I)D
public fun getInt (I)I
public fun getKeyOffset (I)I
public fun getLong (I)J
public fun getMapBuffer (I)Lcom/facebook/react/common/mapbuffer/MapBuffer;
public fun getMapBufferList (I)Ljava/util/List;
public fun getString (I)Ljava/lang/String;
public fun getType (I)Lcom/facebook/react/common/mapbuffer/MapBuffer$DataType;
public fun iterator ()Ljava/util/Iterator;
public final fun put (ID)Lcom/facebook/react/common/mapbuffer/WritableMapBuffer;
public final fun put (II)Lcom/facebook/react/common/mapbuffer/WritableMapBuffer;
public final fun put (IJ)Lcom/facebook/react/common/mapbuffer/WritableMapBuffer;
public final fun put (ILcom/facebook/react/common/mapbuffer/MapBuffer;)Lcom/facebook/react/common/mapbuffer/WritableMapBuffer;
public final fun put (ILjava/lang/String;)Lcom/facebook/react/common/mapbuffer/WritableMapBuffer;
public final fun put (IZ)Lcom/facebook/react/common/mapbuffer/WritableMapBuffer;
}

public final class com/facebook/react/config/ReactFeatureFlags {
public static final field INSTANCE Lcom/facebook/react/config/ReactFeatureFlags;
public static field dispatchPointerEvents Z
Expand Down
14 changes: 7 additions & 7 deletions ...ative/ReactAndroid/src/main/java/com/facebook/react/common/mapbuffer/WritableMapBuffer.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import javax.annotation.concurrent.NotThreadSafe
@StableReactNativeAPI
@NotThreadSafe
@DoNotStrip
public class WritableMapBuffer : MapBuffer {
internal class WritableMapBuffer : MapBuffer {
private val values: SparseArray<Any> = SparseArray<Any>()

/*
Expand All @@ -37,7 +37,7 @@ public class WritableMapBuffer : MapBuffer {
* @param value entry value
* @throws IllegalArgumentException if key is out of [UShort] range
*/
public fun put(key: Int, value: Boolean): WritableMapBuffer = putInternal(key, value)
fun put(key: Int, value: Boolean): WritableMapBuffer = putInternal(key, value)

/**
* Adds an int value for given key to the MapBuffer.
Expand All @@ -46,7 +46,7 @@ public class WritableMapBuffer : MapBuffer {
* @param value entry value
* @throws IllegalArgumentException if key is out of [UShort] range
*/
public fun put(key: Int, value: Int): WritableMapBuffer = putInternal(key, value)
fun put(key: Int, value: Int): WritableMapBuffer = putInternal(key, value)

/**
* Adds a long value for given key to the MapBuffer.
Expand All @@ -55,7 +55,7 @@ public class WritableMapBuffer : MapBuffer {
* @param value entry value
* @throws IllegalArgumentException if key is out of [UShort] range
*/
public fun put(key: Int, value: Long): WritableMapBuffer = putInternal(key, value)
fun put(key: Int, value: Long): WritableMapBuffer = putInternal(key, value)

/**
* Adds a double value for given key to the MapBuffer.
Expand All @@ -64,7 +64,7 @@ public class WritableMapBuffer : MapBuffer {
* @param value entry value
* @throws IllegalArgumentException if key is out of [UShort] range
*/
public fun put(key: Int, value: Double): WritableMapBuffer = putInternal(key, value)
fun put(key: Int, value: Double): WritableMapBuffer = putInternal(key, value)

/**
* Adds a string value for given key to the MapBuffer.
Expand All @@ -73,7 +73,7 @@ public class WritableMapBuffer : MapBuffer {
* @param value entry value
* @throws IllegalArgumentException if key is out of [UShort] range
*/
public fun put(key: Int, value: String): WritableMapBuffer = putInternal(key, value)
fun put(key: Int, value: String): WritableMapBuffer = putInternal(key, value)

/**
* Adds a [MapBuffer] value for given key to the current MapBuffer.
Expand All @@ -82,7 +82,7 @@ public class WritableMapBuffer : MapBuffer {
* @param value entry value
* @throws IllegalArgumentException if key is out of [UShort] range
*/
public fun put(key: Int, value: MapBuffer): WritableMapBuffer = putInternal(key, value)
fun put(key: Int, value: MapBuffer): WritableMapBuffer = putInternal(key, value)

private fun putInternal(key: Int, value: Any): WritableMapBuffer {
require(key in KEY_RANGE) {
Expand Down