Assert if NativeModuleRegistry.onBatchComplete() is used in new architecture#50164
Closed
mdvacca wants to merge 11 commits into
Closed
Assert if NativeModuleRegistry.onBatchComplete() is used in new architecture#50164mdvacca wants to merge 11 commits into
mdvacca wants to merge 11 commits into
Conversation
Summary: Remove UIManagerModule from comments changelog: [internal] internal Differential Revision: D70738950
Summary: Compile out UIManagerModule from ReactTextView changelog: [internal] internal Differential Revision: D70738949
Summary: UIManagerType.DEFAULT is becoming confusings As we are expanding the usage of the New architecture everywhere. That's why I'm depreacting this constant and introducing UIManagerType.LEGACY. changelog: [Android][Deprecated] Deprecate UIManagerType.DEFAULT Differential Revision: D70738948
Summary: Compile-out UIManagerModule from ReactHostImpl changelog: [internal] internal Differential Revision: D70742208
Summary: Compile-out UIManagerModule from ReactModalHostView changelog: [internal] internal Differential Revision: D70742206
Summary: Ensure UIManagerHelper does not access UIManagerModule changelog: [ineternal] internal Differential Revision: D70742205
Summary: In this diff I'm removing UIManager dependency out of ReactInstance class changelog: [internal] internal Differential Revision: D71003821
…intainVisibleScrollPositionHelper.getUIManager() Summary: This diff renames MaintainVisibleScrollPositionHelper.getUIManagerModule() -> MaintainVisibleScrollPositionHelper.getUIManager() to move away from the UIManagerModule naming changelog: [internal\ internal Differential Revision: D71050639
Summary: In this diff we are removing UIManagerModule from NativeAnimatedModule This code wasn't executing when fabric is enabled, with this change the code that references UIManagerModule will be stripped out changelog: [internal] internal Differential Revision: D71050641
Summary: Compile-out UIManagerModule from ReactSafeAreaView changelog: [internal] internal Differential Revision: D71050640
…tecture Summary: Based on analysis this method is only used by legacy architecture, this diff adds an assert if NativeModuleRegistry.onBatchComplete() is used in new architecture changelog: [internal] internal Reviewed By: cortinico Differential Revision: D71050638
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71050638 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Mar 20, 2025
…tecture (facebook#50164) Summary: Based on analysis this method is only used by legacy architecture, this diff adds an assert if NativeModuleRegistry.onBatchComplete() is used in new architecture changelog: [internal] internal Reviewed By: cortinico Differential Revision: D71050638
Contributor
|
This pull request has been merged in 8d1278e. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Based on analysis this method is only used by legacy architecture, this diff adds an assert if NativeModuleRegistry.onBatchComplete() is used in new architecture
changelog: [internal] internal
Reviewed By: cortinico
Differential Revision: D71050638