Add React-renderercss dependency for 3p libs#50192
Closed
cipolleschi wants to merge 1 commit into
Closed
Conversation
Summary: Third party libraries depend transitively agains the React-renderercss modules because it is imported by Fabric. Without this change, the use_frameworks on iOS does not works when a 3P library is imported. This changes fix the behavior and we need to cherry pick them in 0.79. ## Changelog: [iOS][Fixed] - Make sure 3p libraries depends on React-renderercss to work with use_frameworks Differential Revision: D71618395
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71618395 |
Contributor
|
This pull request has been merged in cc12caa. |
Collaborator
|
This pull request was successfully merged by @cipolleschi in cc12caa When will my fix make it into a release? | How to file a pick request? |
react-native-bot
pushed a commit
that referenced
this pull request
Mar 21, 2025
Summary: Pull Request resolved: #50192 Third party libraries depend transitively agains the React-renderercss modules because it is imported by Fabric. Without this change, the use_frameworks on iOS does not works when a 3P library is imported. This changes fix the behavior and we need to cherry pick them in 0.79. ## Changelog: [iOS][Fixed] - Make sure 3p libraries depends on React-renderercss to work with use_frameworks Reviewed By: fabriziocucci Differential Revision: D71618395 fbshipit-source-id: 70c12dcbeb2dfa5fd7513c27d5c069a1f3c95966
Collaborator
|
This pull request was successfully merged by @cipolleschi in 5d26c51 When will my fix make it into a release? | How to file a pick request? |
This was referenced Apr 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Third party libraries depend transitively agains the React-renderercss modules because it is imported by Fabric.
Without this change, the use_frameworks on iOS does not works when a 3P library is imported.
This changes fix the behavior and we need to cherry pick them in 0.79.
Changelog:
[iOS][Fixed] - Make sure 3p libraries depends on React-renderercss to work with use_frameworks
Differential Revision: D71618395