Killswitch accessibilityOrder on iOS and Android#50303
Closed
joevilches wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71919847 |
joevilches
force-pushed
the
export-D71919847
branch
from
46a7376 to
d0948c2
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71919847 |
joevilches
force-pushed
the
export-D71919847
branch
from
d0948c2 to
d6d1cc9
Compare
joevilches
force-pushed
the
export-D71919847
branch
from
d6d1cc9 to
40ac29f
Compare
joevilches
force-pushed
the
export-D71919847
branch
from
40ac29f to
49280cb
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71919847 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71919847 |
joevilches
force-pushed
the
export-D71919847
branch
from
49280cb to
daeeea4
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71919847 |
joevilches
force-pushed
the
export-D71919847
branch
from
daeeea4 to
df9205b
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71919847 |
joevilches
force-pushed
the
export-D71919847
branch
from
df9205b to
7470141
Compare
joevilches
force-pushed
the
export-D71919847
branch
from
7470141 to
96e678b
Compare
Summary: Pull Request resolved: facebook#50303 This feature is being tested internally right now. We cannot really avoid exposing the type but we are going to make this no-op for now in OSS until we are confident we can roll it out fully Changelog: [Internal] Reviewed By: philIip Differential Revision: D71919847
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71919847 |
joevilches
force-pushed
the
export-D71919847
branch
from
96e678b to
b3cb895
Compare
Contributor
|
This pull request has been merged in f75f261. |
Collaborator
|
This pull request was successfully merged by @joevilches in f75f261 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
In case something is wrong with our implementation when we expose this we should add a killswitch. The gating is around the props setting in both iOS and Android, which I feel like is the simplest spot.
Changelog: [Internal]
Reviewed By: jorge-cab
Differential Revision: D71919847