Fix nullsafe FIXMES for ReconnectingWebSocket.java and mark nullsafe#50354
Closed
GijsWeterings wants to merge 12 commits intofacebook:mainfrom
Closed
Fix nullsafe FIXMES for ReconnectingWebSocket.java and mark nullsafe#50354GijsWeterings wants to merge 12 commits intofacebook:mainfrom
GijsWeterings wants to merge 12 commits intofacebook:mainfrom
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71979606 |
…-native/ReactAndroid/src/main/java/com/facebook/react/fabric/mounting/MountItemDispatcher.java Summary: Added nullsafe FIXMEs for easier reviewing of next diff, where we fix them Changelog: Internal Differential Revision: D71979596
Summary: Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations. Changelog: [Android][Fixed] Made MountItemDispatcher.java nullsafe Differential Revision: D71979589
…-native/ReactAndroid/src/main/java/com/facebook/react/fabric/mounting/MountingManager.java Summary: Added nullsafe FIXMEs for easier reviewing of next diff, where we fix them Changelog: Internal Differential Revision: D71979593
Summary: Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations. Changelog: [Android][Fixed] Made MountingManager.java nullsafe Differential Revision: D71979607
…-native/ReactAndroid/src/main/java/com/facebook/react/modules/blob/BlobProvider.java Summary: Added nullsafe FIXMEs for easier reviewing of next diff, where we fix them Changelog: Internal Differential Revision: D71979586
Summary: Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations. Changelog: [Android][Fixed] Made BlobProvider.java nullsafe Differential Revision: D71979597
…-native/ReactAndroid/src/main/java/com/facebook/react/modules/blob/FileReaderModule.java Summary: Added nullsafe FIXMEs for easier reviewing of next diff, where we fix them Changelog: Internal Differential Revision: D71979587
Summary: Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations. Changelog: [Android][Fixed] Made FileReaderModule.java nullsafe Differential Revision: D71979585
…-native/ReactAndroid/src/main/java/com/facebook/react/modules/dialog/DialogModule.java Summary: Added nullsafe FIXMEs for easier reviewing of next diff, where we fix them Changelog: Internal Differential Revision: D71979584
Summary: Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations. Changelog: [Android][Fixed] Made DialogModule.java nullsafe Differential Revision: D71979604
…-native/ReactAndroid/src/main/java/com/facebook/react/packagerconnection/ReconnectingWebSocket.java Summary: Added nullsafe FIXMEs for easier reviewing of next diff, where we fix them Changelog: Internal Differential Revision: D71979580
GijsWeterings
force-pushed
the
export-D71979606
branch
from
0733e27 to
11c3f7e
Compare
…acebook#50354) Summary: Pull Request resolved: facebook#50354 Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations. Changelog: [Android][Fixed] Made ReconnectingWebSocket.java nullsafe Reviewed By: cortinico Differential Revision: D71979606
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71979606 |
GijsWeterings
force-pushed
the
export-D71979606
branch
from
11c3f7e to
487615b
Compare
Contributor
|
This pull request has been merged in ff6601b. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations.
Changelog: [Android][Fixed] Made ReconnectingWebSocket.java nullsafe
Differential Revision: D71979606