fix nullsafe FIXMEs for SurfaceMountingManager.java and mark nullsafe #50369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71979577 |
GijsWeterings
force-pushed
the
export-D71979577
branch
from
5e5b4b7 to
37ba5ed
Compare
GijsWeterings
added a commit
to GijsWeterings/react-native
that referenced
this pull request
Apr 4, 2025
…facebook#50369) Summary: Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations. Changelog: [Android][Fixed] Made SurfaceMountingManager.java nullsafe Reviewed By: javache Differential Revision: D71979577
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71979577 |
GijsWeterings
added a commit
to GijsWeterings/react-native
that referenced
this pull request
Apr 4, 2025
…facebook#50369) Summary: Pull Request resolved: facebook#50369 Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations. Changelog: [Android][Fixed] Made SurfaceMountingManager.java nullsafe Reviewed By: javache Differential Revision: D71979577
GijsWeterings
force-pushed
the
export-D71979577
branch
2 times, most recently
from
67d1697 to
12370a9
Compare
GijsWeterings
added a commit
to GijsWeterings/react-native
that referenced
this pull request
Apr 4, 2025
…facebook#50369) Summary: Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations. Changelog: [Android][Fixed] Made SurfaceMountingManager.java nullsafe Reviewed By: javache Differential Revision: D71979577
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71979577 |
GijsWeterings
force-pushed
the
export-D71979577
branch
from
12370a9 to
6d1df50
Compare
GijsWeterings
added a commit
to GijsWeterings/react-native
that referenced
this pull request
Apr 4, 2025
…facebook#50369) Summary: Pull Request resolved: facebook#50369 Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations. Changelog: [Android][Fixed] Made SurfaceMountingManager.java nullsafe Reviewed By: javache Differential Revision: D71979577
GijsWeterings
force-pushed
the
export-D71979577
branch
from
6d1df50 to
de50829
Compare
GijsWeterings
added a commit
to GijsWeterings/react-native
that referenced
this pull request
Apr 7, 2025
…facebook#50369) Summary: Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations. Changelog: [Android][Fixed] Made SurfaceMountingManager.java nullsafe Reviewed By: javache Differential Revision: D71979577
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71979577 |
GijsWeterings
added a commit
to GijsWeterings/react-native
that referenced
this pull request
Apr 7, 2025
…facebook#50369) Summary: Pull Request resolved: facebook#50369 Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations. Changelog: [Android][Fixed] Made SurfaceMountingManager.java nullsafe Reviewed By: javache Differential Revision: D71979577
GijsWeterings
force-pushed
the
export-D71979577
branch
2 times, most recently
from
88f3a9b to
01368f1
Compare
GijsWeterings
added a commit
to GijsWeterings/react-native
that referenced
this pull request
Apr 7, 2025
…facebook#50369) Summary: Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations. Changelog: [Android][Fixed] Made SurfaceMountingManager.java nullsafe Reviewed By: javache Differential Revision: D71979577
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71979577 |
GijsWeterings
added a commit
to GijsWeterings/react-native
that referenced
this pull request
Apr 7, 2025
…facebook#50369) Summary: Pull Request resolved: facebook#50369 Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations. Changelog: [Android][Fixed] Made SurfaceMountingManager.java nullsafe Reviewed By: javache Differential Revision: D71979577
GijsWeterings
force-pushed
the
export-D71979577
branch
from
01368f1 to
f3d6329
Compare
GijsWeterings
added a commit
to GijsWeterings/react-native
that referenced
this pull request
Apr 7, 2025
…facebook#50369) Summary: Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations. Changelog: [Android][Fixed] Made SurfaceMountingManager.java nullsafe Reviewed By: javache Differential Revision: D71979577
GijsWeterings
force-pushed
the
export-D71979577
branch
from
f3d6329 to
f3ae601
Compare
GijsWeterings
added a commit
to GijsWeterings/react-native
that referenced
this pull request
Apr 7, 2025
…facebook#50369) Summary: Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations. Changelog: [Android][Fixed] Made SurfaceMountingManager.java nullsafe Reviewed By: javache Differential Revision: D71979577
GijsWeterings
force-pushed
the
export-D71979577
branch
from
f3ae601 to
707c0e6
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71979577 |
GijsWeterings
added a commit
to GijsWeterings/react-native
that referenced
this pull request
Apr 7, 2025
…facebook#50369) Summary: Pull Request resolved: facebook#50369 Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations. Changelog: [Android][Fixed] Made SurfaceMountingManager.java nullsafe Reviewed By: javache Differential Revision: D71979577
GijsWeterings
force-pushed
the
export-D71979577
branch
2 times, most recently
from
881c609 to
426b011
Compare
GijsWeterings
added a commit
to GijsWeterings/react-native
that referenced
this pull request
Apr 8, 2025
…facebook#50369) Summary: Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations. Changelog: [Android][Fixed] Made SurfaceMountingManager.java nullsafe Reviewed By: javache Differential Revision: D71979577
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71979577 |
GijsWeterings
force-pushed
the
export-D71979577
branch
from
426b011 to
4b16c24
Compare
…-native/ReactAndroid/src/main/java/com/facebook/react/fabric/mounting/SurfaceMountingManager.java (facebook#50359) Summary: Pull Request resolved: facebook#50359 Added nullsafe FIXMEs for easier reviewing of next diff, where we fix them Changelog: [Internal] Differential Revision: D71979578
GijsWeterings
added a commit
to GijsWeterings/react-native
that referenced
this pull request
Apr 9, 2025
…facebook#50369) Summary: Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations. Changelog: [Android][Fixed] Made SurfaceMountingManager.java nullsafe Reviewed By: javache Differential Revision: D71979577
GijsWeterings
force-pushed
the
export-D71979577
branch
from
4b16c24 to
77e1284
Compare
…facebook#50369) Summary: Pull Request resolved: facebook#50369 Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations. Changelog: [Android][Fixed] Made SurfaceMountingManager.java nullsafe Reviewed By: javache Differential Revision: D71979577
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71979577 |
GijsWeterings
force-pushed
the
export-D71979577
branch
from
77e1284 to
9cad4d3
Compare
Collaborator
|
This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
react-native-bot
added
the
Stale
Collaborator
|
This PR is stale because it has been open for 180 days with no activity. It will be closed in 7 days unless you comment on it or remove the "Stale" label. |
react-native-bot
removed
the
Stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Gone trough all the FIXMEs added in the previous diff by the nullsafe tool, marked the class as nullsafe and ensured no remaining violations.
Changelog: [Android][Fixed] Made SurfaceMountingManager.java nullsafe
Differential Revision: D71979577