'[skip ci] [RN][Android][Sustainability] Migrate to Kotlin - DebugCorePackage#50521
Closed
cortinico wants to merge 3 commits into
Closed
'[skip ci] [RN][Android][Sustainability] Migrate to Kotlin - DebugCorePackage#50521cortinico wants to merge 3 commits into
cortinico wants to merge 3 commits into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72556867 |
Summary: This diff migrates the following file to Kotlin - ReactInstanceDevHelper as part of our ongoing effort of migrating the codebase to Kotlin Changelog: [Android] [Changed] - Migrate to Kotlin - ReactInstanceDevHelper. Some users implementing this class in Kotlin could have breakages. As this is a devtools/frameworks API we're not marking this as breaking. Differential Revision: D72555226
Summary: This diff migrates the following file to Kotlin - DevSupportManagerFactory as part of our ongoing effort of migrating the codebase to Kotlin Changelog: [Android] [Changed] - Migrate to Kotlin - DevSupportManagerFactory - We couldn't find any implementation of this class in OSS. Some Kotlin implementers might have to change the method signatures. However this interface is not supposed to be extended in OSS. Differential Revision: D72556310
Summary: Pull Request resolved: facebook#50521 This diff migrates the following file to Kotlin - DebugCorePackage as part of our ongoing effort of migrating the codebase to Kotlin Changelog: [Internal] [Changed] - Migrate to Kotlin - DebugCorePackage Reviewed By: javache Differential Revision: D72556867
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72556867 |
cortinico
force-pushed
the
export-D72556867
branch
from
5a35015 to
dbf100e
Compare
Contributor
|
This pull request has been merged in f87ae24. |
Collaborator
|
This pull request was successfully merged by @cortinico in f87ae24 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This diff migrates the following file to Kotlin - DebugCorePackage
as part of our ongoing effort of migrating the codebase to Kotlin
Changelog:
[Internal] [Changed] - Migrate to Kotlin - DebugCorePackage
Differential Revision: D72556867