'[skip ci] [react-native] Use @JvmOverloads in Task#50547
Closed
javache wants to merge 3 commits into
Closed
Conversation
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72600052 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72600052 |
3902c1c to
1d7fe08
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72600052 |
1d7fe08 to
8227ed8
Compare
…-native/ReactAndroid/src/main/java/com/facebook/react/runtime/ReactHostImpl.java Summary: Added nullsafe FIXMEs for easier reviewing of next diff, where we fix them Changelog: [Internal] Differential Revision: D72384065
…ebook#50548) Summary: Pull Request resolved: facebook#50548 Changelog: [Internal] Reviewed By: cortinico Differential Revision: D72578962
Summary: Pull Request resolved: facebook#50547 Remove duplication and instead use JvmOverloads to expose all variants to Java Changelog: [Internal] Reviewed By: alanleedev Differential Revision: D72600052
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72600052 |
8227ed8 to
c8802eb
Compare
Contributor
|
This pull request has been merged in b0c3613. |
Collaborator
|
This pull request was successfully merged by @javache in b0c3613 When will my fix make it into a release? | How to file a pick request? |
uffoltzl
pushed a commit
to uffoltzl/react-native
that referenced
this pull request
Apr 18, 2025
Summary: Pull Request resolved: facebook#50547 Remove duplication and instead use JvmOverloads to expose all variants to Java Changelog: [Internal] Reviewed By: alanleedev Differential Revision: D72600052 fbshipit-source-id: a92c75a49ee74f13f3d7bfba6a394099bfaac291
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Remove duplication and instead use JvmOverloads to expose all variants to Java
Changelog: [Internal]
Differential Revision: D72600052'