Make class internal - Package com.facebook.react.views.text.internal.span#50563
Closed
cortinico wants to merge 2 commits into
Closed
Make class internal - Package com.facebook.react.views.text.internal.span#50563cortinico wants to merge 2 commits into
cortinico wants to merge 2 commits into
Conversation
Summary: This diff makes the following file internal - BridgelessCatalystInstance as part of our ongoing effort of reducing the API surface. I've verified that there are no meaningful OSS usage of this class: https://github.com/search?type=code&q=NOT+is%3Afork+NOT+org%3Afacebook+NOT+repo%3Areact-native-tvos%2Freact-native-tvos+NOT+repo%3Anuagoz%2Freact-native+NOT+repo%3A2lambda123%2Freact-native+NOT+repo%3Abeanchips%2Ffacebookreactnative+NOT+repo%3AfabOnReact%2Freact-native-notes+NOT+user%3Ahuntie+NOT+user%3Acortinico+NOT+repo%3AMaxdev18%2Fpowersync_app+NOT+repo%3Acarter-0%2Finstagram-decompiled+NOT+repo%3Am0mosenpai%2Finstadamn+NOT+repo%3AA-Star100%2FA-Star100-AUG2-2024+NOT+repo%3Alclnrd%2Fdetox-scrollview-reproductible+NOT+repo%3ADionisisChytiris%2FWorldWiseTrivia_Main+NOT+repo%3Apast3l%2Fhi2+NOT+repo%3AoneDotpy%2FCaribouQuest+NOT+repo%3Abejayoharen%2Fdailytodo+NOT+repo%3Amolangning%2Freversing-discord+NOT+repo%3AScottPrzy%2Freact-native+NOT+repo%3Agabrieldonadel%2Freact-native-visionos+NOT+repo%3AGabriel2308%2FTestes-Soft+NOT+repo%3Adawnzs03%2FflakyBuild+NOT+repo%3Acga2351%2Fcode+NOT+repo%3Astreeg%2Ftcc+NOT+repo%3Asoftware-mansion-labs%2Freact-native-swiftui+NOT+repo%3Apkcsecurity%2Fdecompiled-lightbulb+com.facebook.react.runtime.BridgelessCatalystInstance Changelog: [Internal] [Changed] - BridgelessCatalystInstance to internal Differential Revision: D72644963
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72644962 |
cortinico
force-pushed
the
export-D72644962
branch
from
598765b to
beeb1ed
Compare
…span (facebook#50563) Summary: Pull Request resolved: facebook#50563 This diff makes all the classes inside `com.facebook.react.views.text.internal.span` internal. Those classes are already inside an `.internal` package. By making them `internal` with the Kotlin keyword we're making harder for them to be accidentally referenced outside React Native. as part of our ongoing effort of reducing the API surface. Changelog: [Internal] [Changed] - com.facebook.react.views.text.internal.span is now internal Differential Revision: D72644962
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72644962 |
cortinico
force-pushed
the
export-D72644962
branch
from
beeb1ed to
0198320
Compare
Contributor
|
This pull request has been merged in f42dae1. |
Collaborator
|
This pull request was successfully merged by @cortinico in f42dae1 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This diff makes all the classes inside
com.facebook.react.views.text.internal.spaninternal.Those classes are already inside an
.internalpackage. By making theminternalwith the Kotlin keywordwe're making harder for them to be accidentally referenced outside React Native.
as part of our ongoing effort of reducing the API surface.
Changelog:
[Internal] [Changed] - com.facebook.react.views.text.internal.span is now internal
Differential Revision: D72644962