Introduce UseReactNativeNewArchitectureFeatureFlagDetector #50607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Mark ReactPackageLogger as LegacyArchitecture changelog: [internal] internal Reviewed By: shwanton Differential Revision: D72067076
…FY_LEGACY_ARCHITECTURE == true Summary: ReactBuildConfig.UNSTABLE_ENABLE_MINIFY_LEGACY_ARCHITECTURE asume Fabric and TurboModule interops are disabled, in this diff I'm adding an assertion to validate this at runtime changelog: [internal] internal Reviewed By: mlord93 Differential Revision: D71854550
Summary: In order to help Proguard to stripping-out bytecode, we need a way to statically enable all Feature Flags used by the New Architecture at build time (e.g. enableBridgelessArchitecture, useTurboModule, etc). The React Native Feature Flag system is mostly implemented in C++ and unfortunately Proguard can’t follow C++ code to understand what feature flags are enabled or disabled at build time. After analyzing several proposals, we decided to introduce a new internal API called ReactNativeNewArchitectureFeatureFlags, this API will help us detect if an app is using the new architecture at build time. In order to make this API to work I’ve migrated all usages of new architecture feature flags from ReactNativeFeatureFlags -> ReactNativeNewArchitectureFeatureFlags changelog: [internal] internal Reviewed By: mlord93 Differential Revision: D71988912
…lags for new architecture feature flags Summary: This diff migrates all usages of new architecture feature flags from ReactNativeFeatureFlags -> ReactNativeNewArchitectureFeatureFlags changelog: [internal] internal Reviewed By: alanleedev Differential Revision: D71988913
Summary: In this diff I'm introducing a new lint error called UseReactNativeNewArchitectureFeatureFlagDetector to prevent usages of: ``` ReactNativeFeatureFlags.enableBridgelessArchitecture ReactNativeFeatureFlags.enableFabricRenderer ReactNativeFeatureFlags.useFabricInterop ReactNativeFeatureFlags.useTurboModuleInterop ReactNativeFeatureFlags.useTurboModules ``` in favor of: ``` ReactNativeNewArchitectureFeatureFlags.enableBridgelessArchitecture ReactNativeNewArchitectureFeatureFlags.enableFabricRenderer ReactNativeNewArchitectureFeatureFlags.useFabricInterop ReactNativeNewArchitectureFeatureFlags.useTurboModuleInterop ReactNativeNewArchitectureFeatureFlags.useTurboModules ``` I created lint by following: https://www.internalfb.com/wiki/Android-lint/adding-a-new-lint-detector/ Reviewed By: cortinico Differential Revision: D72028734
facebook-github-bot
added
CLA Signed
Member
|
Merged as 767462a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In this diff I'm introducing a new lint error called UseReactNativeNewArchitectureFeatureFlagDetector to prevent usages of:
in favor of:
I created lint by following: https://www.internalfb.com/wiki/Android-lint/adding-a-new-lint-detector/
Reviewed By: cortinico
Differential Revision: D72028734