Make class internal - ReactTextInputShadowNode #50647
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72854896 |
Summary: This diff converts another class to Kotlin - ReactTextInputShadowNode Changelog: [Internal] [Changed] - ReactTextInputShadowNode to Kotlin Differential Revision: D72854819
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72854896 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Apr 11, 2025
Summary: Pull Request resolved: facebook#50647 This diff makes the following file internal - ReactTextInputShadowNode as part of our ongoing effort of reducing the API surface. There is only one usage in OSS: `react-native-aztec`. The library is abandoned with little weekly download so we should be good marking this as internal. Changelog: [Internal] [Changed] - ReactTextInputShadowNode is now internal. Differential Revision: D72854896
cortinico
force-pushed
the
export-D72854896
branch
from
1a5b91a to
5be0f78
Compare
…extInputShadowNode (facebook#50647) Summary: Pull Request resolved: facebook#50647 This diff makes the following file internal - ReactTextInputShadowNode as part of our ongoing effort of reducing the API surface. There is only one usage in OSS: . The library is abandoned with little weekly download so we should be good marking this as internal. Changelog: [Internal] [Changed] - ReactTextInputShadowNode is now internal. Differential Revision: D72854896
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72854896 |
cortinico
force-pushed
the
export-D72854896
branch
from
5be0f78 to
8cb65ee
Compare
Contributor
|
This pull request has been merged in 02aa7e7. |
Collaborator
|
This pull request was successfully merged by @cortinico in 02aa7e7 When will my fix make it into a release? | How to file a pick request? |
uffoltzl
pushed a commit
to uffoltzl/react-native
that referenced
this pull request
Apr 18, 2025
Summary: Pull Request resolved: facebook#50647 This diff makes the following file internal - ReactTextInputShadowNode as part of our ongoing effort of reducing the API surface. There is only one usage in OSS: `react-native-aztec`. The library is abandoned with little weekly download so we should be good marking this as internal. Changelog: [Internal] [Changed] - ReactTextInputShadowNode is now internal. Reviewed By: javache Differential Revision: D72854896 fbshipit-source-id: 27512704ed84e893ae72d26469527276133a6295
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff makes the following file internal - ReactTextInputShadowNode
as part of our ongoing effort of reducing the API surface.
There is only one usage in OSS:
react-native-aztec. The library is abandonedwith little weekly download so we should be good marking this as internal.
Changelog:
[Internal] [Changed] - ReactTextInputShadowNode is now internal.
Differential Revision: D72854896