'[skip ci] [RN][Android][Sustainability] Extract inner classes from ReactTextInputManager to separate files #50657
+425
−437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This diff converts another class to Kotlin - ReactTextInputShadowNode Changelog: [Internal] [Changed] - ReactTextInputShadowNode to Kotlin Differential Revision: D72854819
Summary: This diff makes the following file internal - ReactTextInputShadowNode as part of our ongoing effort of reducing the API surface. There is only one usage in OSS: `react-native-aztec`. The library is abandoned with little weekly download so we should be good marking this as internal. Changelog: [Internal] [Changed] - ReactTextInputShadowNode is now internal. Differential Revision: D72854896
…eactTextInputManager to separate files Summary: The ReactTextInputManager file is huge and really hard to migrate to Kotlin. Here I'\''m extracting 4 private inner classes to separate files and converting them to Kotlin. This will make reviewing the Kotlin migration of ReactTextInputManager a bit easier. Changelog: [Internal] [Changed] - Differential Revision: D72858396
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72858396 |
Contributor
|
This pull request has been merged in 70cdf12. |
uffoltzl
pushed a commit
to uffoltzl/react-native
that referenced
this pull request
Apr 18, 2025
…acebook#50657) Summary: Pull Request resolved: facebook#50657 The ReactTextInputManager file is huge and really hard to migrate to Kotlin. Here I'm extracting 4 private inner classes to separate files and converting them to Kotlin. This will make reviewing the Kotlin migration of ReactTextInputManager a bit easier. Changelog: [Internal] [Changed] - Reviewed By: rshest Differential Revision: D72858396 fbshipit-source-id: 1fcca1b8421c810aa4bf9fdca7656f4e805565d8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The ReactTextInputManager file is huge and really hard to migrate to Kotlin.
Here I'''m extracting 4 private inner classes to separate files and converting them to Kotlin.
This will make reviewing the Kotlin migration of ReactTextInputManager a bit easier.
Changelog:
[Internal] [Changed] -
Differential Revision: D72858396