Remove obsolete @TargetApi annotations for Lollipop (API 21)#50686
Closed
mateoguzmana wants to merge 2 commits into
Closed
Remove obsolete @TargetApi annotations for Lollipop (API 21)#50686mateoguzmana wants to merge 2 commits into
@TargetApi annotations for Lollipop (API 21)#50686mateoguzmana wants to merge 2 commits into
Conversation
facebook-github-bot
added
the
CLA Signed
mateoguzmana
changed the title
mateoguzmana
changed the title
@TargetApi annotations for LOLLIPOP (API 21)
facebook-github-bot
added
the
Shared with Meta
mateoguzmana
changed the title
@TargetApi annotations for LOLLIPOP (API 21)@TargetApi annotations for Lollipop (API 21)
Contributor
|
@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
Collaborator
|
This pull request was successfully merged by @mateoguzmana in 6f2357a When will my fix make it into a release? | How to file a pick request? |
uffoltzl
pushed a commit
to uffoltzl/react-native
that referenced
this pull request
Apr 18, 2025
…ook#50686) Summary: Static code analysis detected obsolete SDK version checks. Since [the minimum supported SDK version is API 24](react-native-community/discussions-and-proposals#802), these checks for API 21 are no longer necessary and can be safely removed. ## Changelog: [INTERNAL] - Remove obsolete TargetApi annotations for LOLLIPOP (API 21) Pull Request resolved: facebook#50686 Test Plan: ```sh yarn test-android yarn android ``` CI should be green. Reviewed By: cortinico Differential Revision: D72948073 Pulled By: rshest fbshipit-source-id: 1dd1415364d19f115771de3643cdc023a247d851
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Static code analysis detected obsolete SDK version checks.
Since the minimum supported SDK version is API 24, these checks for API 21 are no longer necessary and can be safely removed.
Changelog:
[INTERNAL] - Remove obsolete @TargetApi annotations for LOLLIPOP (API 21)
Test Plan:
CI should be green.