[RN][CI] Fix check nightlies by escaping the artifact folder#50726
Closed
cipolleschi wants to merge 1 commit intomainfrom
Closed
[RN][CI] Fix check nightlies by escaping the artifact folder#50726cipolleschi wants to merge 1 commit intomainfrom
cipolleschi wants to merge 1 commit intomainfrom
Conversation
facebook-github-bot
added
CLA Signed
cipolleschi
force-pushed
the
cipolleschi/fix-check-nightlies
branch
5 times, most recently
from
b4272f3 to
81332f9
Compare
cipolleschi
force-pushed
the
cipolleschi/fix-check-nightlies
branch
from
81332f9 to
f17d4a8
Compare
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@cipolleschi merged this pull request in b028f84. |
uffoltzl
pushed a commit
to uffoltzl/react-native
that referenced
this pull request
Apr 18, 2025
Summary: The check nightlies job is failing on some libraries because the library key contains `/` and ` ` characters that fails to be used properly when they are part of a path. With this change, we are replacing those characters with `_` so this is a valid path were CI can save the outcome that needs to be collected later. ## Changelog: [Internal] - Fix folder path Pull Request resolved: facebook#50726 Test Plan: Running in GHA Reviewed By: cortinico Differential Revision: D73036049 Pulled By: cipolleschi fbshipit-source-id: 147b9fa15b4dfa08e94f01715e5a175479230d80
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The check nightlies job is failing on some libraries because the library key contains
/andWith this change, we are replacing those characters with
_so this is a valid path were CI can save the outcome that needs to be collected later.Changelog:
[Internal] - Fix folder path
Test Plan:
Running in GHA