Fix Type comparison (v2) in TurboModuleInteropUtils.kt #50794
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: instead of explictly specifying fully qualified Java boxed types, use proper Kotlin syntax to refer to it. --- 👉 Notes on Java <> Kotlin type mapping !!! See: Kotlin's Mapped Types; https://kotlinlang.org/docs/java-interop.html#mapped-types - kotlin `Boolean` maps to Java's primitive type `boolean` and not boxed Type `Boolean` - Java boxed type `Boolean` maps to `Boolean?` in Kotlin So in Kotlin, - `Boolean::class.java` refers to Java primitive type `Class<boolean>` which is equivalent to `Boolean::class.javaPrimitiveType` - For boxed type use `Boolean::class.javaObjectType` == `Class<Boolean>` **TIP:** When dealing with Java primitive types using reflection, use `::class.javaPrimtiveType` or `::class.javaObjectType` to avoid the confusion with using plain `::class.java`. Differential Revision: D73224138
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D73224138 |
Member
|
Merged as 1fb04e2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
instead of explictly specifying fully qualified Java boxed types, use proper Kotlin syntax to refer to it.
👉 Notes on Java <> Kotlin type mapping !!!
See: Kotlin's Mapped Types; https://kotlinlang.org/docs/java-interop.html#mapped-types
Booleanmaps to Java's primitive typebooleanand not boxed TypeBooleanBooleanmaps toBoolean?in KotlinSo in Kotlin,
Boolean::class.javarefers to Java primitive typeClass<boolean>which is equivalent toBoolean::class.javaPrimitiveTypeBoolean::class.javaObjectType==Class<Boolean>TIP: When dealing with Java primitive types using reflection, use
::class.javaPrimtiveTypeor::class.javaObjectTypeto avoid the confusion with using plain::class.java.Differential Revision: D73224138