Take 2: Mitigate deadlock hazard in RCTUtils.m #50807
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D73265906 |
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Apr 18, 2025
Summary:
This structure is unsafe:
```
// In each native module:
+load
dispatch_once
NSBundle mainBundle
```
NSBundle mainBundle itself uses dispatch_once during initialization. If that initialization triggers a native module class load, we could end up with a circular dependency chain. This could deadlock the application.
## Changes
Just remove the dispatch_once. Getting the NSBundle mainBundle is very efficient after the first access. And NSBundle objectForInfoDictionaryKey is also very efficient.
Created from CodeHub with https://fburl.com/edit-in-codehub
Changelog: [Internal]
Reviewed By: NickGerleman
Differential Revision: D73265906
RSNara
force-pushed
the
export-D73265906
branch
from
05c90f9 to
0a0ae77
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D73265906 |
RSNara
force-pushed
the
export-D73265906
branch
from
0a0ae77 to
73cd828
Compare
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Apr 18, 2025
Summary: Pull Request resolved: facebook#50807 This structure is unsafe: ``` // In each native module: +load dispatch_once NSBundle mainBundle ``` NSBundle mainBundle itself uses dispatch_once during initialization. If that initialization triggers a native module class load, we could end up with a circular dependency chain. This could deadlock the application. ## Changes Just remove the dispatch_once. Getting the NSBundle mainBundle is very efficient after the first access. And NSBundle objectForInfoDictionaryKey is also very efficient. Created from CodeHub with https://fburl.com/edit-in-codehub Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D73265906
RSNara
force-pushed
the
export-D73265906
branch
from
73cd828 to
245e3fa
Compare
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Apr 21, 2025
Summary:
This structure is unsafe:
```
// In each native module:
+load
dispatch_once
NSBundle mainBundle
```
NSBundle mainBundle itself uses dispatch_once during initialization. If that initialization triggers a native module class load, we could end up with a circular dependency chain. This could deadlock the application.
## Changes
Just remove the dispatch_once. Getting the NSBundle mainBundle is very efficient after the first access. And NSBundle objectForInfoDictionaryKey is also very efficient.
Created from CodeHub with https://fburl.com/edit-in-codehub
Changelog: [Internal]
Reviewed By: NickGerleman
Differential Revision: D73265906
Summary: Pull Request resolved: facebook#50807 This structure is unsafe: ``` // In each native module: +load dispatch_once NSBundle mainBundle ``` NSBundle mainBundle itself uses dispatch_once during initialization. If that initialization triggers a native module class load, we could end up with a circular dependency chain. This could deadlock the application. ## Changes Just remove the dispatch_once. Getting the NSBundle mainBundle is very efficient after the first access. And NSBundle objectForInfoDictionaryKey is also very efficient. Created from CodeHub with https://fburl.com/edit-in-codehub Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D73265906
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D73265906 |
RSNara
force-pushed
the
export-D73265906
branch
from
245e3fa to
1298375
Compare
Collaborator
|
This pull request was successfully merged by @RSNara in aa41184 When will my fix make it into a release? | How to file a pick request? |
Contributor
|
This pull request has been merged in aa41184. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This structure is unsafe:
NSBundle mainBundle itself uses dispatch_once during initialization. If that initialization triggers a native module class load, we could end up with a circular dependency chain. This could deadlock the application.
Changes
Just remove the dispatch_once. Getting the NSBundle mainBundle is very efficient after the first access. And NSBundle objectForInfoDictionaryKey is also very efficient.
Created from CodeHub with https://fburl.com/edit-in-codehub
Changelog: [Internal]
Reviewed By: NickGerleman
Differential Revision: D73265906