add view culling tests when flattetning and deleting a subtree#50860
Closed
sammy-SC wants to merge 2 commits into
Closed
add view culling tests when flattetning and deleting a subtree#50860sammy-SC wants to merge 2 commits into
sammy-SC wants to merge 2 commits into
Conversation
Differential Revision: D73454202
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D73493001 |
sammy-SC
force-pushed
the
export-D73493001
branch
from
5f7b757 to
af1b992
Compare
…ook#50860) Summary: Pull Request resolved: facebook#50860 changelog: [internal] Adding a test case verifying branch of code starting in [Differentiator:855](https://github.com/facebook/react-native/blob/main/packages/react-native/ReactCommon/react/renderer/mounting/Differentiator.cpp#L855) Without using `adjustedOldCullingContext` in the branch, it leads to a crash on [StubViewTree:177](https://github.com/facebook/react-native/blob/main/packages/react-native/ReactCommon/react/renderer/mounting/stubs/StubViewTree.cpp#L177): trying to remove view that does not exist. Reviewed By: lenaic Differential Revision: D73493001
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D73493001 |
sammy-SC
force-pushed
the
export-D73493001
branch
from
af1b992 to
ce4d549
Compare
Contributor
|
This pull request has been merged in d40b4c6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
changelog: [internal]
Adding a test case verifying branch of code starting in Differentiator:855
Without using
adjustedOldCullingContextin the branch, it leads to a crash on StubViewTree:177: trying to remove view that does not exist.Differential Revision: D73493001