TypeScript: Replace deprecated React.ElementRef usages to React.ComponentRef#50883
Closed
mateoguzmana wants to merge 1 commit into
Closed
TypeScript: Replace deprecated React.ElementRef usages to React.ComponentRef#50883mateoguzmana wants to merge 1 commit into
mateoguzmana wants to merge 1 commit into
Conversation
Contributor
|
@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
Collaborator
|
This pull request was successfully merged by @mateoguzmana in 12147e3 When will my fix make it into a release? | How to file a pick request? |
Contributor
|
This didn't go far enough - the deprecated React.ElementRef is still a strict requirement in the codegen phase: https://github.com/search?q=repo%3Afacebook%2Freact-native%20React.ElementRef%3C%3E&type=code I suppose I should log a new issue as there isn't one currently |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
While upgrading a project to React 19, I noticed React.ElementRef is deprecated (see types/react/index.d.ts#L199). I think we can replace it for the RN types as well.
Not sure if this is considered as a breaking change.
Changelog:
[GENERAL] [CHANGED] - TypeScript: Replace deprecated React.ElementRef usages to React.ComponentRef
Test Plan:
Create a RNTesterPlayground.tsx next to the normal .js just to validate the type checking is not throwing an unexpected error.
Code snippet: