Fix EXC_BAD_ACCESS within RCTInspectorNetworkReporter#50952
Closed
sanjay-io wants to merge 1 commit intofacebook:mainfrom
Closed
Fix EXC_BAD_ACCESS within RCTInspectorNetworkReporter#50952sanjay-io wants to merge 1 commit intofacebook:mainfrom
sanjay-io wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: This attempts to fix a crash introduced a few weeks ago: https://fburl.com/logview/8s19uu9b Sapienz caught the crash over here: D71470038 You can see on line 664, we do a check for task.requestId, but not on the line that we added a safety around. Differential Revision: D73720844
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D73720844 |
Collaborator
Contributor
|
This pull request has been merged in 7a919d6. |
Collaborator
|
This pull request was successfully merged by Sanjay Thakur in 7a919d6 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: [Internal]