Split proguard for legacy / new architecture #50955
Closed
+37
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71577597 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71577597 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
May 1, 2025
Summary: Pull Request resolved: facebook#50955 In this diff I'm splitting proguard rules for apps using legacy architecture or apps running 100% in new architecture APIs This split will be controlled by the config: enable_minify_legacy_architecture() changelog: [internal] internal Reviewed By: shwanton, javache Differential Revision: D71577597
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71577597 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71577597 |
Summary: Adding IgnoreStringLiterals in DefaultDevSupportManagerFactory class to prevent proguard to keep the BridgeDevSupportManager class changelog: [internal] internal Differential Revision: D72090836
Summary: Pull Request resolved: facebook#50955 In this diff I'm splitting proguard rules for apps using legacy architecture or apps running 100% in new architecture APIs This split will be controlled by the config: enable_minify_legacy_architecture() changelog: [internal] internal Reviewed By: shwanton, javache Differential Revision: D71577597
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D71577597 |
Collaborator
|
This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
react-native-bot
added
the
Stale
Collaborator
|
This PR was closed because it has been stalled for 7 days with no activity. |
1 similar comment
Collaborator
|
This PR was closed because it has been stalled for 7 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In this diff I'm splitting proguard rules for apps using legacy architecture or apps running 100% in new architecture APIs
This split will be controlled by the config: enable_minify_legacy_architecture()
changelog: [internal] internal
Reviewed By: shwanton, javache
Differential Revision: D71577597