Make ResourceDrawableIdHelper an object #51013
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D73923281 |
javache
added a commit
to javache/react-native
that referenced
this pull request
Apr 30, 2025
Summary: There's no need to use a singleton pattern here, we can just use a Kotlin object. Changelog: [Android][Removed] Deprecated `ResourceDrawableIdHelper.instance` Reviewed By: Abbondanzo Differential Revision: D73923281
javache
force-pushed
the
export-D73923281
branch
from
8eebd7c to
bf122e6
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D73923281 |
javache
added a commit
to javache/react-native
that referenced
this pull request
Apr 30, 2025
Summary: Pull Request resolved: facebook#51013 There's no need to use a singleton pattern here, we can just use a Kotlin object. Changelog: [Android][Removed] Deprecated `ResourceDrawableIdHelper.instance` Reviewed By: Abbondanzo Differential Revision: D73923281
javache
force-pushed
the
export-D73923281
branch
from
bf122e6 to
493f011
Compare
Differential Revision: D73923280
javache
added a commit
to javache/react-native
that referenced
this pull request
Apr 30, 2025
Summary: There's no need to use a singleton pattern here, we can just use a Kotlin object. Changelog: [Android][Removed] Deprecated `ResourceDrawableIdHelper.instance` Reviewed By: Abbondanzo Differential Revision: D73923281
javache
force-pushed
the
export-D73923281
branch
from
493f011 to
2f4b2a7
Compare
Summary: Pull Request resolved: facebook#51013 There's no need to use a singleton pattern here, we can just use a Kotlin object. Changelog: [Android][Removed] Deprecated `ResourceDrawableIdHelper.instance` Reviewed By: Abbondanzo Differential Revision: D73923281
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D73923281 |
javache
force-pushed
the
export-D73923281
branch
from
2f4b2a7 to
dc855a1
Compare
Contributor
|
This pull request has been merged in 8de401c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
There's no need to use a singleton pattern here, we can just use a Kotlin object.
Changelog: [Android][Removed] Deprecated
ResourceDrawableIdHelper.instanceDifferential Revision: D73923281