Used shared_ptr<Runtime> in jsi testlib #51081
Closed
+86
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70113190 |
Summary: Add JSI castInterface API. This provides a structured way to provide optional APIs that may or may not be supported in all engines. Every interface will have its own set of APIs. For instance, Hermes will provide an interface (`IHermes`) containing Hermes-specific APIs. In the future, an interface may be created to expose optional APIs. A runtime will inherit the interfaces of which the APIs are supported by the runtime. Users who want to access a specific API may call castInterface with the UUID of interface containing the API. For backwards compatibility, the current `jsi::Runtime` will remain as an object, and its functionalities will not be described by an interface. However, this may be revisited later. Changelog: [Internal] Reviewed By: tmikov Differential Revision: D68964360
Summary: After introducing the interfaces, runtime should be managed through a shared pointer instead of a unique pointer. This diff will change the usage in JSI testlib. Later diffs will actually change the HermesRuntime usages. Reviewed By: lavenzg Differential Revision: D70113190
tsaichien
force-pushed
the
export-D70113190
branch
from
0201a34 to
e06005f
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70113190 |
facebook-github-bot
pushed a commit
to facebook/hermes
that referenced
this pull request
May 14, 2025
Summary: X-link: facebook/react-native#51081 After introducing the interfaces, runtime should be managed through a shared pointer instead of a unique pointer. This diff will change the usage in JSI testlib. Later diffs will actually change the HermesRuntime usages. Changelog: [Internal] Reviewed By: lavenzg Differential Revision: D70113190 fbshipit-source-id: ea831dd8f79750851fd626afe0f1f5550142ac05
facebook-github-bot
pushed a commit
to facebook/hermes
that referenced
this pull request
May 14, 2025
Summary: X-link: facebook/react-native#51081 After introducing the interfaces, runtime should be managed through a shared pointer instead of a unique pointer. This diff will change the usage in JSI testlib. Later diffs will actually change the HermesRuntime usages. Changelog: [Internal] Reviewed By: lavenzg Differential Revision: D70113190 fbshipit-source-id: ea831dd8f79750851fd626afe0f1f5550142ac05
Contributor
|
This pull request has been merged in 6766cf6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
After introducing the interfaces, runtime should be managed through a
shared pointer instead of a unique pointer.
This diff will change the usage in JSI testlib. Later diffs will
actually change the HermesRuntime usages.
Reviewed By: lavenzg
Differential Revision: D70113190