[ios][prebuild] replaced use of rsync with cp in prebuild scripts#51095
Closed
chrfalch wants to merge 1 commit into
Closed
[ios][prebuild] replaced use of rsync with cp in prebuild scripts#51095chrfalch wants to merge 1 commit into
chrfalch wants to merge 1 commit into
Conversation
When building the RNDependencies XCFrameworks we saw some errors in the CI servers about rsync failing: `rsync(3031): error: poll: hangup on nonblocking write` We decided to fix this by changing from using rsync to cp. This commit fixes this by replacing rsync with cp, and adding a cleanup step after copying the XCFramework files.
facebook-github-bot
added
the
CLA Signed
facebook-github-bot
added
the
Shared with Meta
cipolleschi
approved these changes
May 6, 2025
Contributor
cipolleschi
left a comment
cipolleschi
left a comment
There was a problem hiding this comment.
Thanks for fixing this!
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@cipolleschi merged this pull request in 3ac16dd. |
Collaborator
|
This pull request was successfully merged by @chrfalch in 3ac16dd When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
When building the RNDependencies XCFrameworks we saw some errors in the CI servers about rsync failing:
rsync(3031): error: poll: hangup on nonblocking writeWe decided to fix this by changing from using rsync to cp.
This commit fixes this by replacing rsync with cp, and adding a cleanup step after copying the XCFramework files.
Changelog:
[INTERNAL] [FIXED] - Replacing rsync with cp, and adding a cleanup step after copying the XCFramework files.
Test Plan:
Run RNDependencies scripts on CI and verify that they're working as expected.