community-cli-plugin: Refactor CLI build command to use Metro.runBuild#51124
Closed
robhogan wants to merge 1 commit into
Closed
community-cli-plugin: Refactor CLI build command to use Metro.runBuild#51124robhogan wants to merge 1 commit into
robhogan wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D74151840 |
Job Summary for GradleTest All :: build_android
|
robhogan
force-pushed
the
export-D74151840
branch
from
4906c5d to
d0b9571
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D74151840 |
robhogan
force-pushed
the
export-D74151840
branch
2 times, most recently
from
8272ac8 to
08053df
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D74151840 |
robhogan
added a commit
that referenced
this pull request
May 23, 2025
#51124) Summary: Pull Request resolved: #51124 Metro 0.82.3's `runBuild` API now supports retrieving assets and passing through `unstable_transformProfile`, and fine control of output paths via `bundleOut`/`sourcemapOut`, so we can use it directly in the implementation of `community-cli-plugin`'s `bundle` command with no loss of function or API change. This simplifies the implementation by re-using Metro's, and removes use of Metro internal APIs. Reviewed By: huntie Differential Revision: D74151840
robhogan
force-pushed
the
export-D74151840
branch
from
08053df to
030c156
Compare
facebook-github-bot
force-pushed
the
export-D74151840
branch
from
030c156 to
79a9bb8
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D74151840 |
robhogan
force-pushed
the
export-D74151840
branch
from
79a9bb8 to
a067efe
Compare
#51124) Summary: Pull Request resolved: #51124 Metro 0.82.3's `runBuild` API now supports retrieving assets and passing through `unstable_transformProfile`, and fine control of output paths via `bundleOut`/`sourcemapOut`, so we can use it directly in the implementation of `community-cli-plugin`'s `bundle` command with no loss of function or API change. This simplifies the implementation by re-using Metro's, and removes use of Metro internal APIs. Changelog: [Internal] Reviewed By: huntie Differential Revision: D74151840
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D74151840 |
robhogan
force-pushed
the
export-D74151840
branch
from
a067efe to
342afb9
Compare
Collaborator
|
This pull request was successfully merged by @robhogan in 342afb9 When will my fix make it into a release? | How to file a pick request? |
Collaborator
|
This pull request was successfully merged by @robhogan in a3447d6 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Metro 0.82.3's
runBuildAPI now supports retrieving assets and passing throughunstable_transformProfile, so we can use it directly in the implementation ofcommunity-cli-plugin'sbundlecommand with no loss of function or API change.This simplifies the implementation by re-using Metro's, and removes use of Metro internal APIs.
Changelog: [Internal]
Differential Revision: D74151840