Reland: Migrate PromiseImpl to Kotlin
#51273
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctor/migrate-promise-impl-to-kotlin
facebook-github-bot
added
the
CLA Signed
Member
|
Can you leave a note on what has changed compared to the initial version? |
facebook-github-bot
added
the
Shared with Meta
Contributor
Nothing has changed. We had to reverted the diff as it caused several test failures internally but it was green when landing. We'll have to investigate why this was the case. |
Contributor
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
Collaborator
|
This pull request was successfully merged by @mateoguzmana in c62d952 When will my fix make it into a release? | How to file a pick request? |
Member
|
Just fyi, the missing change here was a @DoNotStrip on the constructor to prevent proguard from removing this method which was called by C++. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Reland of #51241, which had to be reverted due to a crash.
Migrate com.facebook.react.bridge.PromiseImpl to Kotlin.
In this diff, nothing has changed yet as from the original PR. Awaiting for next steps to apply new changes #51241 (comment)
Changelog:
[INTERNAL] - Migrate com.facebook.react.bridge.PromiseImpl to Kotlin
Test Plan: