Add boxShadow prop diffing to View component#51314
Closed
lenaic wants to merge 2 commits into
Closed
Conversation
added 2 commits
May 14, 2025 05:29
Summary: The nativeID and testID prop mapping on the native Java side use full caps `ID` in the setter mapping. Fixing the props diffing result to use the right key in the result for both. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D74724759
Summary: See title Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D74726605
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D74726605 |
lenaic
pushed a commit
to lenaic/react-native-macos
that referenced
this pull request
May 14, 2025
Summary: See title Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D74726605
lenaic
pushed a commit
to lenaic/react-native-macos
that referenced
this pull request
May 14, 2025
Summary: See title Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D74726605
Contributor
|
This pull request has been merged in 85994c9. |
Collaborator
|
This pull request was successfully merged by Nick Lefever in 85994c9 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
See title
Changelog: [Internal]
Reviewed By: sammy-SC
Differential Revision: D74726605