Use methodSignatureForSelector instead of instanceMethodSignatureForSelector #51366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elector Summary: We inherited this from the legacy native module infra, where we didn't have access to the module instance. Instead we can use the simpler `methodSignatureForSelector` which works correctly with OCMock (needed in D74815079). Changelog: [Internal] Differential Revision: D74817191
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D74817191 |
javache
added a commit
to javache/react-native
that referenced
this pull request
May 15, 2025
…elector (facebook#51366) Summary: We inherited this from the legacy native module infra, where we didn't have access to the module instance. Instead we can use the simpler `methodSignatureForSelector` which works correctly with OCMock (needed in D74815079). Changelog: [Internal] Differential Revision: D74817191
javache
added a commit
to javache/react-native
that referenced
this pull request
May 15, 2025
…elector (facebook#51366) Summary: We inherited this from the legacy native module infra, where we didn't have access to the module instance. Instead we can use the simpler `methodSignatureForSelector` which works correctly with OCMock (needed in D74815079). Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D74817191
javache
added a commit
to javache/react-native
that referenced
this pull request
May 15, 2025
…elector (facebook#51366) Summary: We inherited this from the legacy native module infra, where we didn't have access to the module instance. Instead we can use the simpler `methodSignatureForSelector` which works correctly with OCMock (needed in D74815079). Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D74817191
javache
added a commit
to javache/react-native
that referenced
this pull request
May 16, 2025
…elector (facebook#51366) Summary: We inherited this from the legacy native module infra, where we didn't have access to the module instance. Instead we can use the simpler `methodSignatureForSelector` which works correctly with OCMock (needed in D74815079). Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D74817191
Contributor
|
This pull request has been merged in 05dee83. |
Collaborator
|
This pull request was successfully merged by @javache in 05dee83 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We inherited this from the legacy native module infra, where we didn't have access to the module instance. Instead we can use the simpler
methodSignatureForSelectorwhich works correctly with OCMock (needed in D74815079).Changelog: [Internal]
Differential Revision: D74817191