Fix structuredClone test and added test to clarify behavior in IntersectionObserver#51476
Closed
rubennorte wants to merge 1 commit into
Closed
Fix structuredClone test and added test to clarify behavior in IntersectionObserver#51476rubennorte wants to merge 1 commit into
rubennorte wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75073118 |
rubennorte
force-pushed
the
export-D75073118
branch
from
085eadb to
62649fa
Compare
rubennorte
force-pushed
the
export-D75073118
branch
from
62649fa to
e6da9bc
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75073118 |
…ectionObserver (facebook#51476) Summary: Pull Request resolved: facebook#51476 Changelog: [internal] When we added integration of IntersectionObserver in the event loop by default, we changed the timing of the observer notification: - Before, it was scheduled synchronously from the `observe` call. That means that, if you schedule another task immediately after the observe call, the order is IO callback then task. - After, it was scheduled at the end of the current event loop tick. That means that, if you schedule another task immediately after the observe call, the order is task then IO callback. This change in order wasn't accounted for in the tests for IO (which it's added here) and made a test for `structuredClone` break because it was using incorrect assumptions. This fixes that test. Reviewed By: rshest Differential Revision: D75073118
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75073118 |
rubennorte
force-pushed
the
export-D75073118
branch
from
e6da9bc to
dc14ff9
Compare
Contributor
|
This pull request has been merged in 6581c69. |
Collaborator
|
This pull request was successfully merged by @rubennorte in 6581c69 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
When we added integration of IntersectionObserver in the event loop by default, we changed the timing of the observer notification:
observecall. That means that, if you schedule another task immediately after the observe call, the order is IO callback then task.This change in order wasn't accounted for in the tests for IO (which it's added here) and made a test for
structuredClonebreak because it was using incorrect assumptions.This fixes that test.
Differential Revision: D75073118