Add documentation to the SwiftPM structure#51532
Closed
cipolleschi wants to merge 2 commits into
Closed
Conversation
Summary: To reduce reduntant code by repeating the logging functionality in each JS module, this commit introduces a factory for creating a logger with a given prefix. - Create factory `createLogger` - Remove redundant log implementations - Changed to use factory in hermes.js and ios-prebuild.js ## Changelog: [IOS] [CHANGED] - simplified logging in prebuild scripts Pull Request resolved: facebook#51527 Test Plan: No tests so far. Differential Revision: D75213656
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75217331 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75217331 |
cipolleschi
force-pushed
the
export-D75217331
branch
from
3ea4cfc to
5a8e9a8
Compare
Summary: Pull Request resolved: facebook#51532 This change adds documentation to the SwiftPM structure to simplify changing it, especially if we have to port some changes from the cocoapods infra to the Swift PM implementation. ## Changelog: [Internal] - Add docs Reviewed By: cortinico Differential Revision: D75217331
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75217331 |
cipolleschi
force-pushed
the
export-D75217331
branch
from
5a8e9a8 to
00f7408
Compare
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
May 22, 2025
Summary: Pull Request resolved: facebook#51532 This change adds documentation to the SwiftPM structure to simplify changing it, especially if we have to port some changes from the cocoapods infra to the Swift PM implementation. ## Changelog: [Internal] - Add docs Differential Revision: D75217331 Reviewed By: cortinico
Contributor
|
This pull request has been merged in 66ec4b3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This change adds documentation to the SwiftPM structure to simplify changing it, especially if we have to port some changes from the cocoapods infra to the Swift PM implementation.
Changelog:
[Internal] - Add docs
Differential Revision: D75217331