Consolidate location for Flow libdefs#51539
Closed
huntie wants to merge 1 commit into
Closed
Conversation
Summary: Follow up to D70322032. Relocates some of our newly added Flow library definitions into the package level `flow/` directory, to help disambiguate their use. **Types directories after changes** `packages/react-native/` - `flow/` — Longstanding location for Flow package/global library definitions. Not imported by source code. - `src/types/` — Contains public typedefs useful to 3P consumers (TypeScript) (today, just `globals.d.ts` as one module). Not imported by source code. - `src/private/types/` — Source type modules **in Flow**, that **are imported** by other files in `src/private/`. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D75060846
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75060846 |
Contributor
|
This pull request has been merged in 44e36e6. |
Collaborator
|
This pull request was successfully merged by @huntie in 44e36e6 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Follow up to D70322032. Relocates some of our newly added Flow library definitions into the package level
flow/directory, to help disambiguate their use.Types directories after changes
packages/react-native/flow/— Longstanding location for Flow package/global library definitions. Not imported by source code.src/types/— Contains public typedefs useful to 3P consumers (TypeScript) (today, justglobals.d.tsas one module). Not imported by source code.src/private/types/— Source type modules in Flow, that are imported by other files insrc/private/.Changelog: [Internal]
Reviewed By: christophpurrer
Differential Revision: D75060846