Skip to content

Disable hasOverlappingRendering in PreparedLayoutTextView #51549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NickGerleman wants to merge 1 commit into from
Closed

Disable hasOverlappingRendering in PreparedLayoutTextView #51549

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ...native/ReactAndroid/src/main/java/com/facebook/react/views/text/PreparedLayoutTextView.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,6 +278,11 @@ internal class PreparedLayoutTextView(context: Context) : ViewGroup(context), Re
return delegateHandled || super.dispatchKeyEvent(event)
}

// This potentially a lie, to avoid clipping outside of layout bounds when we are translucent, at
// the cost of incorrect alpha blending.
// TODO T225199534: Add support for "needsOffscreenAlphaCompositing" to Text
override fun hasOverlappingRendering(): Boolean = false

@RequiresApi(api = Build.VERSION_CODES.UPSIDE_DOWN_CAKE)
private object Api34Utils {
private var highlightPaths: List<Path>? = null
Expand Down
Loading