Fix missing height constraints when creating Fabric layout for adjustsFontSizeToFit#51550
Closed
NickGerleman wants to merge 1 commit into
Closed
Fix missing height constraints when creating Fabric layout for adjustsFontSizeToFit#51550NickGerleman wants to merge 1 commit into
adjustsFontSizeToFit#51550NickGerleman wants to merge 1 commit into
Conversation
…tsFontSizeToFit` Summary: `adjustsFontSizeToFit` will adjust font size so that given text fits in both veritcal and horizontal bounds. The algorithm to mutate text to fit is executed during TextLayoutManager during layout creation for Fabric, and then re-executed in `TextView.onDraw()`. See D56134348 which introduced the logic. In Facsimile, we were not seeing font size adjusted when text is too tall. This is because we are only incorporating the height constraint during Spannable mutation during draw, but not the original layout, which Facsimile uses directly. This could potentially fix other bugs, where width may not corredpond to the final font size we settle on during drawing. Changelog: [Android][Fixed] - Fix missing height constraints when creating Fabric layout for `adjustsFontSizeToFit` Reviewed By: mdvacca Differential Revision: D75251391
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75251391 |
Contributor
|
This pull request has been merged in b70c73d. |
Collaborator
|
This pull request was successfully merged by @NickGerleman in b70c73d When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
adjustsFontSizeToFitwill adjust font size so that given text fits in both veritcal and horizontal bounds. The algorithm to mutate text to fit is executed during TextLayoutManager during layout creation for Fabric, and then re-executed inTextView.onDraw(). See D56134348 which introduced the logic.In Facsimile, we were not seeing font size adjusted when text is too tall. This is because we are only incorporating the height constraint during Spannable mutation during draw, but not the original layout, which Facsimile uses directly.
This could potentially fix other bugs, where width may not corredpond to the final font size we settle on during drawing.
Changelog:
[Android][Fixed] - Fix missing height constraints when creating Fabric layout for
adjustsFontSizeToFitReviewed By: mdvacca
Differential Revision: D75251391