introduce a way to inspect shadow node revision in Fantom#51566
Closed
sammy-SC wants to merge 1 commit into
Closed
introduce a way to inspect shadow node revision in Fantom#51566sammy-SC wants to merge 1 commit into
sammy-SC wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75287261 |
sammy-SC
force-pushed
the
export-D75287261
branch
from
b38c39c to
038202c
Compare
…1566) Summary: Pull Request resolved: facebook#51566 changelog: [internal] Expose [revision](https://github.com/facebook/react-native/blob/main/packages/react-native/ReactCommon/react/renderer/core/ShadowNode.h#L229) of shadow node in Fantom tests. This makes it possible to write tests verifying that shadow nodes are only cloned when they should. Even though excessive cloning does not usually lead to bugs, it may lead to performance problems. Also introduce a test showing a performance problem where changing height of "Sibling" view from 1 to 2 will lead to component `D` being cloned by Yoga. Component D is not affected by the size change of Sibling and the clone is unnecessary. ```jsx <ScrollView> <View id="Sibling" style={{ height: 1 }} /> <View id="A"> <View id="B"> <View id="C"> <View id="D" ref={ref} /> </View> </View> </View> </ScrollView> ``` Reviewed By: rshest Differential Revision: D75287261
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75287261 |
sammy-SC
force-pushed
the
export-D75287261
branch
from
038202c to
46f6f3a
Compare
Contributor
|
This pull request has been merged in afb5436. |
Collaborator
|
This pull request was successfully merged by @sammy-SC in afb5436 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
changelog: [internal]
Expose revision of shadow node in Fantom tests. This makes it possible to write tests verifying that shadow nodes are only cloned when they should.
Even though excessive cloning does not usually lead to bugs, it may lead to performance problems.
Also introduce a test showing a performance problem where changing height of "Sibling" view from 1 to 2 will lead to component
Dbeing cloned by Yoga. Component D is not affected by the size change of Sibling and the clone is unnecessary.Reviewed By: rshest
Differential Revision: D75287261