remove superclass enable_shared_from_this from AnimationDriver#51611
Closed
sammy-SC wants to merge 3 commits into
Closed
remove superclass enable_shared_from_this from AnimationDriver#51611sammy-SC wants to merge 3 commits into
sammy-SC wants to merge 3 commits into
Conversation
Summary: changelog: [internal] NativeAnimatedNodesManagerProvider is not subclassed. Let's remove virtual methods and make it a final class. Reviewed By: lenaic Differential Revision: D75169108
…gerProvider Summary: changelog: [internal] No need to store uiManagerBinding in a shared_ptr. Let's just get it, pass it to classes that need it and not store it. This helps with C++ binary size a little bit. Reviewed By: rshest Differential Revision: D75174567
Summary: changelog: [internal] AnimationDriver does not use enable_shared_from_this, let's remove it. Also mark a few methods as noexcept and const. This helps with C++ binary size. Reviewed By: rshest Differential Revision: D75172851
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75172851 |
Contributor
|
This pull request has been merged in 6c05300. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
changelog: [internal]
AnimationDriver does not use enable_shared_from_this, let's remove it. Also mark a few methods as noexcept and const.
This helps with C++ binary size.
Reviewed By: rshest
Differential Revision: D75172851