Fix missing willPerformAsynchronously parameter in calls to MountingCoordinator::pullTransaction#51618
Closed
rubennorte wants to merge 1 commit into
Closed
Fix missing willPerformAsynchronously parameter in calls to MountingCoordinator::pullTransaction#51618rubennorte wants to merge 1 commit into
rubennorte wants to merge 1 commit into
Conversation
…oordinator::pullTransaction Summary: Changelog: [internal] This sets the argument to `pullTransaction` to `true` in the cases where the call is done from the JS thread and the transactions are mounted asynchronously in the UI thread (basically platforms using the push model for mounting coordinator). It was missing on an experiment for Android (compatibility mode for Props 2.0) Differential Revision: D75439105
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75439105 |
Contributor
|
This pull request has been merged in 77c8608. |
Collaborator
|
This pull request was successfully merged by @rubennorte in 77c8608 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
This sets the argument to
pullTransactiontotruein the cases where the call is done from the JS thread and the transactions are mounted asynchronously in the UI thread (basically platforms using the push model for mounting coordinator).It was missing on an experiment for Android (compatibility mode for Props 2.0)
Differential Revision: D75439105