Skip to content

clean up AnimationDriverUtils #51674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sammy-SC wants to merge 1 commit into from
Closed

clean up AnimationDriverUtils #51674

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions ...ages/react-native/ReactCxxPlatform/react/renderer/animated/drivers/AnimationDriverUtils.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@

#include <string_view>

namespace facebook::react {

static constexpr std::string_view ExtrapolateTypeIdentity = "identity";
static constexpr std::string_view ExtrapolateTypeClamp = "clamp";
static constexpr std::string_view ExtrapolateTypeExtend = "extend";
Expand All @@ -21,16 +23,14 @@ static constexpr double SingleFrameIntervalMs = 1000.0 / 60.0;

static constexpr double TicksPerMs = 10000.0; // ticks are 100 nanoseconds

namespace {

inline double interpolate(
double inputValue,
double inputMin,
double inputMax,
double outputMin,
double outputMax,
const std::string_view& extrapolateLeft,
const std::string_view& extrapolateRight) {
std::string_view extrapolateLeft,
std::string_view extrapolateRight) {
auto result = inputValue;

// Extrapolate
Expand Down Expand Up @@ -61,4 +61,4 @@ inline double interpolate(
(outputMax - outputMin) * (result - inputMin) / (inputMax - inputMin);
}

} // namespace
} // namespace facebook::react
1 change: 0 additions & 1 deletion ...ages/react-native/ReactCxxPlatform/react/renderer/animated/tests/AnimationDriverTests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@

#include "AnimationTestsBase.h"

#include <react/renderer/animated/drivers/AnimationDriverUtils.h>
#include <react/renderer/core/ReactRootViewTagGenerator.h>

namespace facebook::react {
Expand Down
1 change: 0 additions & 1 deletion ...react-native/ReactCxxPlatform/react/renderer/animated/tests/EventAnimationDriverTests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@

#include "AnimationTestsBase.h"

#include <react/renderer/animated/drivers/AnimationDriverUtils.h>
#include <react/renderer/components/scrollview/ScrollEvent.h>
#include <react/renderer/core/ReactRootViewTagGenerator.h>

Expand Down
Loading