Replace existing usages of shadowNodeFromValue with new bridging function#51676
Closed
rubennorte wants to merge 2 commits into
Closed
Replace existing usages of shadowNodeFromValue with new bridging function#51676rubennorte wants to merge 2 commits into
rubennorte wants to merge 2 commits into
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75597543 |
rubennorte
force-pushed
the
export-D75597543
branch
from
f72a1e3 to
f7a4607
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75597543 |
rubennorte
force-pushed
the
export-D75597543
branch
from
f7a4607 to
33c636d
Compare
rubennorte
force-pushed
the
export-D75597543
branch
from
33c636d to
84c99cd
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75597543 |
rubennorte
force-pushed
the
export-D75597543
branch
from
84c99cd to
bdc6a19
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75597543 |
rubennorte
force-pushed
the
export-D75597543
branch
2 times, most recently
from
81749cb to
ce58ca3
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75597543 |
Differential Revision: D75597542
rubennorte
force-pushed
the
export-D75597543
branch
from
ce58ca3 to
099d099
Compare
…tion (facebook#51676) Summary: Pull Request resolved: facebook#51676 Changelog: [internal] This replaces all existing usages of `shadowNodeFromValue` (previously defined in `primitives.h`) to use the new bridging method to automatically convert `ShadowNode::Shared` from and to JS. It also deletes the old method. Reviewed By: javache Differential Revision: D75597543
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75597543 |
rubennorte
force-pushed
the
export-D75597543
branch
from
099d099 to
3dc5098
Compare
Contributor
|
This pull request has been merged in 25f8b86. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
This replaces all existing usages of
shadowNodeFromValue(previously defined inprimitives.h) to use the new bridging method to automatically convertShadowNode::Sharedfrom and to JS.It also deletes the old method.
Differential Revision: D75597543