Implement textVerticalAlign #51680
Closed
Implement textVerticalAlign #51680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75475915 |
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Jun 2, 2025
Summary: Right now there are 2 flavors of vertical text alignment: `verticalAlign` and `textVerticalAlign`. Both do the same thing currently. For Facsimile, we actually want to "properly" implement `verticalAlign` so that it matches the web version, while leaving `textVerticalAlign` the same. That will take some time, however, so for now we are just going to implement the way it currently works, while fixing some issues with inline View's Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D75475915
joevilches
force-pushed
the
export-D75475915
branch
from
bbf8073 to
d5bd9e3
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75475915 |
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Jun 2, 2025
Summary: Right now there are 2 flavors of vertical text alignment: `verticalAlign` and `textVerticalAlign`. Both do the same thing currently. For Facsimile, we actually want to "properly" implement `verticalAlign` so that it matches the web version, while leaving `textVerticalAlign` the same. That will take some time, however, so for now we are just going to implement the way it currently works, while fixing some issues with inline View's Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D75475915
joevilches
force-pushed
the
export-D75475915
branch
from
d5bd9e3 to
c73601a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75475915 |
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Jun 2, 2025
Summary: Pull Request resolved: facebook#51680 Right now there are 2 flavors of vertical text alignment: `verticalAlign` and `textVerticalAlign`. Both do the same thing currently. For Facsimile, we actually want to "properly" implement `verticalAlign` so that it matches the web version, while leaving `textVerticalAlign` the same. That will take some time, however, so for now we are just going to implement the way it currently works, while fixing some issues with inline View's Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D75475915
joevilches
force-pushed
the
export-D75475915
branch
from
c73601a to
18f8ba1
Compare
Differential Revision: D75643360
Differential Revision: D75684576
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Jun 4, 2025
Summary: Right now there are 2 flavors of vertical text alignment: `verticalAlign` and `textVerticalAlign`. Both do the same thing currently. For Facsimile, we actually want to "properly" implement `verticalAlign` so that it matches the web version, while leaving `textVerticalAlign` the same. That will take some time, however, so for now we are just going to implement the way it currently works, while fixing some issues with inline View's Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D75475915
joevilches
force-pushed
the
export-D75475915
branch
from
18f8ba1 to
0645992
Compare
Summary: Pull Request resolved: facebook#51680 Right now there are 2 flavors of vertical text alignment: `verticalAlign` and `textVerticalAlign`. Both do the same thing currently. For Facsimile, we actually want to "properly" implement `verticalAlign` so that it matches the web version, while leaving `textVerticalAlign` the same. That will take some time, however, so for now we are just going to implement the way it currently works, while fixing some issues with inline View's Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D75475915
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75475915 |
joevilches
force-pushed
the
export-D75475915
branch
from
0645992 to
5cda7f4
Compare
Contributor
|
This pull request has been merged in ed26358. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Right now there are 2 flavors of vertical text alignment:
verticalAlignandtextVerticalAlign. Both do the same thing currently. For Facsimile, we actually want to "properly" implementverticalAlignso that it matches the web version, while leavingtextVerticalAlignthe same. That will take some time, however, so for now we are just going to implement the way it currently works, while fixing some issues with inline View'sNext diff will fix the inline view issue on
ReactTextViewChangelog: [Internal]
Differential Revision: D75475915