-
Notifications
You must be signed in to change notification settings - Fork 25k
Allow parameterizing event types in EventTarget #51700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rubennorte
wants to merge
1
commit into
facebook:main
Choose a base branch
from
rubennorte:export-D75681184
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+191
−111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75681184 |
6c898ad to
e4409b9
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75681184 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
May 30, 2025
Summary: Pull Request resolved: facebook#51700 Changelog: [internal] This adds the ability to strongly type `EventTarget` events via generics. See the next diff for an example of how to use it. Differential Revision: D75681184
e4409b9 to
23a2250
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
May 30, 2025
Summary: Changelog: [internal] This adds the ability to strongly type `EventTarget` events via generics. See the next diff for an example of how to use it. Differential Revision: D75681184
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
May 30, 2025
Summary: Changelog: [internal] This adds the ability to strongly type `EventTarget` events via generics. See the next diff for an example of how to use it. Differential Revision: D75681184
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
May 30, 2025
Summary: Changelog: [internal] This adds the ability to strongly type `EventTarget` events via generics. See the next diff for an example of how to use it. Differential Revision: D75681184
23a2250 to
61770cf
Compare
Summary: Pull Request resolved: facebook#51700 Changelog: [internal] This adds the ability to strongly type `EventTarget` events via generics. See the next diff for an example of how to use it. Differential Revision: D75681184
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75681184 |
61770cf to
7218146
Compare
Collaborator
|
This PR is stale because it has been open for 180 days with no activity. It will be closed in 7 days unless you comment on it or remove the "Stale" label. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
p: Facebook
Partner: Facebook
Partner
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
This adds the ability to strongly type
EventTargetevents via generics.See the next diff for an example of how to use it.
Differential Revision: D75681184