Use PreparedLayout as opposed to Layout in PreparedLayoutTextView #51711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75643360 |
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
May 30, 2025
…cebook#51711) Summary: This is needed to support textVerticalAlign as we are storing that offset in the prepared layout and need to read it from the new text view Changelog: [Internal] Differential Revision: D75643360
joevilches
force-pushed
the
export-D75643360
branch
from
9711763 to
b98fd1d
Compare
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Jun 2, 2025
…cebook#51711) Summary: This is needed to support textVerticalAlign as we are storing that offset in the prepared layout and need to read it from the new text view Changelog: [Internal] Differential Revision: D75643360
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75643360 |
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Jun 2, 2025
…cebook#51711) Summary: Pull Request resolved: facebook#51711 This is needed to support textVerticalAlign as we are storing that offset in the prepared layout and need to read it from the new text view Changelog: [Internal] Differential Revision: D75643360
joevilches
force-pushed
the
export-D75643360
branch
from
b98fd1d to
631d119
Compare
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Jun 2, 2025
…cebook#51711) Summary: This is needed to support textVerticalAlign as we are storing that offset in the prepared layout and need to read it from the new text view Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D75643360
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Jun 2, 2025
…cebook#51711) Summary: This is needed to support textVerticalAlign as we are storing that offset in the prepared layout and need to read it from the new text view Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D75643360
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Jun 2, 2025
…cebook#51711) Summary: This is needed to support textVerticalAlign as we are storing that offset in the prepared layout and need to read it from the new text view Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D75643360
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Jun 2, 2025
…cebook#51711) Summary: This is needed to support textVerticalAlign as we are storing that offset in the prepared layout and need to read it from the new text view Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D75643360
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Jun 2, 2025
…cebook#51711) Summary: This is needed to support textVerticalAlign as we are storing that offset in the prepared layout and need to read it from the new text view Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D75643360
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Jun 4, 2025
…cebook#51711) Summary: This is needed to support textVerticalAlign as we are storing that offset in the prepared layout and need to read it from the new text view Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D75643360
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Jun 4, 2025
…cebook#51711) Summary: This is needed to support textVerticalAlign as we are storing that offset in the prepared layout and need to read it from the new text view Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D75643360
joevilches
force-pushed
the
export-D75643360
branch
from
631d119 to
086747c
Compare
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Jun 4, 2025
…cebook#51711) Summary: This is needed to support textVerticalAlign as we are storing that offset in the prepared layout and need to read it from the new text view Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D75643360
…cebook#51711) Summary: Pull Request resolved: facebook#51711 This is needed to support textVerticalAlign as we are storing that offset in the prepared layout and need to read it from the new text view Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D75643360
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75643360 |
joevilches
force-pushed
the
export-D75643360
branch
from
086747c to
282063e
Compare
Contributor
|
This pull request has been merged in 573ba02. |
Collaborator
|
This pull request was successfully merged by @joevilches in 573ba02 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is needed to support textVerticalAlign as we are storing that offset in the prepared layout and need to read it from the new text view
Changelog: [Internal]
Differential Revision: D75643360