RN: Flowify packages/helloworld
#51789
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75899853 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75899853 |
yungsters
force-pushed
the
export-D75899853
branch
from
0d9d629 to
4dce4b8
Compare
yungsters
added a commit
to yungsters/react-native
that referenced
this pull request
Jun 3, 2025
Summary: Pull Request resolved: facebook#51789 Adds `flow` or `noflow` to the remaining files that are lacking it in the `packages/helloworld` directory. Changelog: [Internal] Differential Revision: D75899853
Summary: Just adding `flow` to these two libdefs that aren't sourced directly from `flow-typed/flow-typed`. Changelog: [Internal] Differential Revision: D75877692
Summary: Adds `noflow` to a bunch of ESLint and Babel files that are expected to be evaluated using Node.js without Babel. Additioanlly, these files tend to depend on ESLint and Babel type definitions that are not currently readily available. In the future, these files could be migrated to use `flow strict-local` or `flow strict` using comment syntax for type annotations. But for now, adding `noflow` makes it explicit that these are known to not be typechecked. Changelog: [Internal] Differential Revision: D75883642
Summary: Adds `noflow` to a bunch of Node.js script files. In the future, these files could be migrated to use `flow strict-local` or `flow strict` using comment syntax for type annotations. But for now, adding `noflow` makes it explicit that these are known to not be typechecked. Changelog: [Internal] Differential Revision: D75883703
Summary: Adds `flow` to the remaining files that are lacking it (or `noflow`) in the `scripts` directory. This also fixes what I believe to be a typo in one of the files. Changelog: [Internal] Differential Revision: D75883851
Summary: Pull Request resolved: facebook#51780 Adds `flow` to the remaining files that are lacking it in the `packages/react-native-codegen` directory. This also adds any necessary type annotations (using comment syntax). Changelog: [Internal] Differential Revision: D75884727
Summary: Adds `noflow` to a test in `packages/react-native-compatibility-check`. In the future, this file should be migrated to use `flow strict-local` or `flow strict`. However, it currently has way too many type errors. Adding `noflow` makes it explicit that this is known to not be typechecked. Changelog: [Internal] Differential Revision: D75885038
Summary: Adds `flow` to the remaining files that are lacking it in the `packages/react-native-fantom` directory. This also adds any necessary type annotations (using comment syntax). Changelog: [Internal] Differential Revision: D75886119
Summary: Adds `flow` to the remaining files that are lacking it in the `packages/virtualized-lists` directory. In one of the Jest tests, there are so many failures that for now, I just added `noflow`. Changelog: [Internal] Differential Revision: D75888514
Summary: Adds `flow` to the remaining files that are lacking it in the `packages/rn-tester` directory. This also adds any necessary type annotations. Changelog: [Internal] Differential Revision: D75899307
Summary: Pull Request resolved: facebook#51789 Adds `flow` or `noflow` to the remaining files that are lacking it in the `packages/helloworld` directory. Changelog: [Internal] Reviewed By: SamChou19815 Differential Revision: D75899853
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75899853 |
yungsters
force-pushed
the
export-D75899853
branch
from
4dce4b8 to
c0539d1
Compare
Contributor
|
This pull request has been merged in 13e0965. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Adds
flowornoflowto the remaining files that are lacking it in thepackages/helloworlddirectory.Changelog:
[Internal]
Differential Revision: D75899853