Fix image loading on props change without layout invalidation #51791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75919671 |
lenaic
pushed a commit
to lenaic/react-native-macos
that referenced
this pull request
Jun 4, 2025
…ok#51791) Summary: On iOS the <Image> shadow node was expecting a layout call for every clone. With `passChildrenWhenCloningPersistedNodes` <Image> components may have the image source updated without layout being called on it due to the re-use of the previous layout data thanks to the improved handling of layout invalidation. This diff triggers the image request as soon as possible if the cloned shadow node has a clean layout. The request will be made as soon as the image manager is set on the shadow node. Changelog: [iOS][Fixed] - Fix RCTImageComponentView image loading after source props change with no layout invalidation Differential Revision: D75919671
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75919671 |
lenaic
pushed a commit
to lenaic/react-native-macos
that referenced
this pull request
Jun 4, 2025
…ok#51791) Summary: Pull Request resolved: facebook#51791 On iOS the <Image> shadow node was expecting a layout call for every clone. With `passChildrenWhenCloningPersistedNodes` <Image> components may have the image source updated without layout being called on it due to the re-use of the previous layout data thanks to the improved handling of layout invalidation. This diff triggers the image request as soon as possible if the cloned shadow node has a clean layout. The request will be made as soon as the image manager is set on the shadow node. Changelog: [iOS][Fixed] - Fix RCTImageComponentView image loading after source props change with no layout invalidation Differential Revision: D75919671
lenaic
pushed a commit
to lenaic/react-native-macos
that referenced
this pull request
Jun 5, 2025
…ok#51791) Summary: On iOS the <Image> shadow node was expecting a layout call for every clone. With `passChildrenWhenCloningPersistedNodes` <Image> components may have the image source updated without layout being called on it due to the re-use of the previous layout data thanks to the improved handling of layout invalidation. This diff triggers the image request as soon as possible if the cloned shadow node has a clean layout. The request will be made as soon as the image manager is set on the shadow node. Changelog: [iOS][Fixed] - Fix RCTImageComponentView image loading after source props change with no layout invalidation Reviewed By: NickGerleman, sammy-SC Differential Revision: D75919671
…ok#51791) Summary: Pull Request resolved: facebook#51791 On iOS the <Image> shadow node was expecting a layout call for every clone. With `passChildrenWhenCloningPersistedNodes` <Image> components may have the image source updated without layout being called on it due to the re-use of the previous layout data thanks to the improved handling of layout invalidation. This diff triggers the image request as soon as possible if the cloned shadow node has a clean layout. The request will be made as soon as the image manager is set on the shadow node. Changelog: [iOS][Fixed] - Fix RCTImageComponentView image loading after source props change with no layout invalidation Reviewed By: NickGerleman, sammy-SC Differential Revision: D75919671
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75919671 |
Contributor
|
This pull request has been merged in cd5d745. |
Collaborator
|
This pull request was successfully merged by Nick Lefever in cd5d745 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:![]()
shadow node was expecting a layout call for every clone. With ![]()
components may have the image source updated without layout being called on it due to the re-use of the previous layout data thanks to the improved handling of layout invalidation.
On iOS the
passChildrenWhenCloningPersistedNodesThis diff triggers the image request as soon as possible if the cloned shadow node has a clean layout. The request will be made as soon as the image manager is set on the shadow node.
Changelog: [iOS][Fixed] - Fix RCTImageComponentView image loading after source props change with no layout invalidation
Differential Revision: D75919671