fix crash on non-critical path, e.g., setTimeout #51793
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Issue: #51664
Exceptions on non-critical path crash the app. This happened locations such as callback in
setTimeout, onPress callback of<Pressable>, less defensive 3rd-parties libraries (on code level) can also crash the app on these paths.Exception in
ReactFabric::extractEventscrashes the app.The above behaviors does not exist in older versions. In React web, exceptions on those paths are treated same way as async operations and are handled by global handler.
Changelog:
[IOS] [FIXED] - Fix crash on non-critical path
Test Plan:
setTimeout:Pressable:ReactFabric::extractEvents