Manually set all fields on scratch TextPaint #51827
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75987605 |
Summary: TextLayoutManager has an optimization today, where it reuses a scratch TextPaint throughout layouts. This is not safe in Facsimile, since we may mutate the paint on a Layout, after it is created, but before it is drawn. This change makes it so that we only ever use a scratch paint, when the layout it is set on does not escape TextLayoutManager. Changelog: [Internal] Differential Revision: D75987605
NickGerleman
force-pushed
the
export-D75987605
branch
from
5bed895 to
ae116b6
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D75987605 |
Contributor
|
This pull request has been merged in 0581e88. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
TextPaint.reset()is buggy, and doesn't always reset all the state. D64535719 fixed this for resetting typeface, but a bug showed up, where we seem to sometimes leakfakeBoldTextas well.Let's remove the
reset(), and explicitly set every field, every time.Changelog:
[Android][Fixed] - Manually set all fields on scratch TextPaint
Differential Revision: D75987605