Migrate ReactPackageTurboModuleManagerDelegate to Kotlin#51855
Migrate ReactPackageTurboModuleManagerDelegate to Kotlin#51855mateoguzmana wants to merge 1 commit into
ReactPackageTurboModuleManagerDelegate to Kotlin#51855Conversation
facebook-github-bot
added
the
CLA Signed
facebook-github-bot
added
the
Shared with Meta
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
| * @param reactContext react application context that can be used to create modules | ||
| * @return list of module specs that can create the native modules | ||
| */ | ||
| protected abstract fun getNativeModules(reactContext: ReactApplicationContext): List<ModuleSpec> |
There was a problem hiding this comment.
Why are you changing this?
There was a problem hiding this comment.
It is being accessed here: https://github.com/facebook/react-native/pull/51855/files#diff-8e5e67fbf42add63f615a128dc2009c2474e5303765d33a64edcc301a3ee80b7R74 – would you know if there is a way to avoid having to make this public?
There was a problem hiding this comment.
mmm that's weird as you should have visibility there because this field is protected already
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @mateoguzmana in 8d76670 When will my fix make it into a release? | How to file a pick request? |
|
@cortinico merged this pull request in 8d76670. |
4 participants
Summary:
Migrate com.facebook.react.ReactPackageTurboModuleManagerDelegate to Kotlin.
Changelog:
[INTERNAL] - Migrate com.facebook.react.ReactPackageTurboModuleManagerDelegate to Kotlin
Test Plan: