RN: Move `{tools => packages}/__tests__#51862
Closed
yungsters wants to merge 6 commits into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76098157 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76098157 |
yungsters
force-pushed
the
export-D76098157
branch
from
391380e to
f682d89
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76098157 |
yungsters
force-pushed
the
export-D76098157
branch
from
f682d89 to
a82cadd
Compare
Summary: Pull Request resolved: facebook#51880 Updates the `sort-imports` lint rule. The main change is that it enforces newlines after the last import statement. Changelog: [Internal] Reviewed By: SamChou19815 Differential Revision: D76149902
Summary: Pull Request resolved: facebook#51881 Switches the suppression of ESLint for the generated `sort-imports` lint rule definition to using in-file comments instead of `.eslintignore`. This makes the suppression more portable. If the path to the lint rule definition changes, we don't have to remember to update `.eslintignore`. Changelog: [Internal] Reviewed By: SamChou19815 Differential Revision: D76152973
Summary: Pull Request resolved: facebook#51858 Creates a new private package for the ESLint rules that are defined in the `facebook/react-native` repository for linting the monorepo itself: `react-native/eslint-plugin-monorepo` It resides in a new `private/` directory that will be used for all private packages. I plan to move private packages over from `packages/` and `tools/`. This also eliminates the need for the `eslint-plugin-lint` dependency in open source. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D76088698
Summary: Pull Request resolved: facebook#51863 Standardizes lint severity in `.eslintrc.js` to use the string format. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D76098593
Summary: Pull Request resolved: facebook#51859 Moves `tools/apis` to `private/cxx-public-api` and cleans up a few things: - Clean up the `BUCK` file a bit. - Deduplicate relative paths in scripts. - Prefix the private package name with `react-native/`. Changelog: [Internal] Reviewed By: huntie Differential Revision: D76091765
Summary: Pull Request resolved: facebook#51862 Moves the dependency tests in `tools/__tests__` to `private/monorepo-tests/__tests__`, allowing us to delete the now-vacant `tools/` directory. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D76098157
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76098157 |
yungsters
force-pushed
the
export-D76098157
branch
from
a82cadd to
a02e868
Compare
Contributor
|
This pull request has been merged in 0fad032. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Moves the dependency tests in
tools/__tests__toscripts/__tests__, allowing us to delete the now-vacanttools/directory.Changelog:
[Internal]
Differential Revision: D76098157